aejsmith / vkdevicechooser

Vulkan layer to force a specific device to be used
MIT License
77 stars 18 forks source link

Not working with Strange Brigade #1

Closed GloriousEggroll closed 5 years ago

GloriousEggroll commented 5 years ago

So, this thing is awesome, I noticed Arlie's PR for mesa and came across this in the comments. However I noticed that while this works for DOOM, for some reason it does not work with Strange Brigade. If you want to skip having to guess where to press on the Strange Brigade launcher for testing, I have a custom proton build that runs the vulkan version of the game directly:

http://github.com/gloriouseggroll/proton-ge-custom

aejsmith commented 5 years ago

Unfortunately I don't own Strange Brigade to be able to test this properly. But, since it supports multi-GPU, I'm guessing that it is using vkEnumeratePhysicalDeviceGroups rather than vkEnumeratePhysicalDevices to enumerate devices, and the layer doesn't currently override that. I'll see if I can implement an override for that over the weekend.

aejsmith commented 5 years ago

I've fixed two issues: vkEnumeratePhysicalDeviceGroups is now overridden, and the layer .json file now advertises Vulkan 1.1 support (before that the loader would refuse to load the layer for apps that request 1.1). Hopefully it'll work now!

GloriousEggroll commented 5 years ago

yessir that did it! Thanks a ton! Strangebrigade