aeksco / react-typescript-web-extension-starter

:desktop_computer: Web Extension starter kit built with React, TypeScript, TailwindCSS, Storybook, Jest, EsLint, Prettier, and Webpack. Supports Google Chrome + Mozilla Firefox + Brave Browser + Microsoft Edge + Opera :fire:

MIT License

929 stars 83 forks source link

Migrate Chrome Extension manfiest.json to V3 #46

Closed punithbm closed 2 years ago

punithbm commented 2 years ago

Description

Migrated the manifest.json file version to V3
Migrated Webextension-polyfill-ts to Webextension-polyfill as mentioned here to support the newer version

Fixes # (issue)

1

Type of change

Please delete options that are not relevant.

[ ] New feature (non-breaking change which adds functionality)
[ ] This change requires a documentation update

How Has This Been Tested?

Tested in chrome browser. Attached screen recording https://drive.google.com/file/d/18vA7UU8i5iXQx13Q2CCj9s3Oco0mW4yR/view?usp=sharing

joshsmith commented 2 years ago

While the new manifest.json was tested in Chrome, the V3 will not work in Firefox:

... we expect to launch MV3 support for all users by the end of 2022.

This breaks cross-browser compatibility for this starter for at least Firefox. Brave apparently plans to continue V2 support past sunset.

This is complicated further by the fact that new Manifest V2 extensions are already not supported by Chrome.

I think we need a new approach to handle how manifest.json is generated for the dist, perhaps on a per-browser basis?