search

aelmosalamy / ascii-combat

A simple CLI text adventure game, created for learning purposes, feel free to contribute.
MIT License
69 stars 17 forks source link

Additions and corrections. #12

Closed Digital-Black closed 5 years ago

Digital-Black commented 5 years ago

I added to the rooms, items and weapon_skills dictionaries and helped with spelling and grammar.

aelmosalamy commented 5 years ago

Thanks mate, this is really helpful, I am going to merge once I commit current changes. My spelling mistakes are horrible though, typing quickly and trying to figure out interesting descriptions at the same time 👍

aelmosalamy commented 5 years ago

Another thing, You think of any applications for the 'Bow'? since it is the same thing like a Spear - in terms of dmg - so I think I will have to come up with some ideas for 'ranged weapons', but I think this can wait since I am currently trying to implement rooms where enemies block your way, so that the combat system joins with the dungeon system.

Digital-Black commented 5 years ago

It definitely seems a good idea to wait on ranged weapons for now, if you're looking to focus on functionality with the dungeon and combat system. I love what I see of your game so-far, and I'm learning a ton from seeing how you've used the code!

aelmosalamy commented 5 years ago

I am very happy that you are learning new stuff from my code, You are always welcome to check the open issues and help at anything, ANYTHING, you think you can do!

I added some new features, now you will get a loading screen leading you to a combat, if you win that combat you can proceed to next room, I am looking forward to add much more rooms so the game can expand and much more items with better descriptions 😄 they will be available in the next commit.

aelmosalamy commented 5 years ago

I merged your pull request! Now ASCII Combat have a bow, a Courtyard and an Evergreen tree 😃 I would love it if you keep adding new content, I really need someone who writes such beautiful descriptions to help me extend the game and make it better 💯 👍 One more thing: you should convert the files to CRLF newlines before sending them to Github, since you are using Linux/Mac OS X