search

aelmosalamy / ascii-combat

A simple CLI text adventure game, created for learning purposes, feel free to contribute.
MIT License
69 stars 17 forks source link

no encoding declared, non-ASCII character #15

Closed iamparkerm closed 5 years ago

iamparkerm commented 5 years ago

Is this written for python 2.x or 3.x?

The error is in dicts__init.py__ line 20: SEP = ' ● '

aelmosalamy commented 5 years ago

Thank you, and yes, this happens when you run it in Python2.x, which needs encoding to be specified; however, ASCII Combat is written in Python3, since it is the latest version, and I am not intending to add Python2 compatibility, It runs perfectly fine in Python3.

iamparkerm commented 5 years ago

Is there a library I need that's missing? I'm running main.py from a python3.6 virtenv and getting that error.

aelmosalamy commented 5 years ago

Can you send me the error details? What operating system are you using?

It should be working fine, go to the game directory and then python main.py

iamparkerm commented 5 years ago

On Win10. In a py3.6 virtenv. The error is: no encoding declared, non-ASCII character. The error is in dictsinit.py line 20: SEP = ' ● '.

I'll try again tonight. I am new to coding, so maybe something is wrong with my virtenv.

Check out my github, I have a very simple text game in python 2. I've updated it to py3 which I'll post. I'd love to help with your game. I'm learning a lot.

aelmosalamy commented 5 years ago

Screenshot the error, and try to run it without without using virtenv, just open a terminal inside ASCII Combat's directory and type in python main.py or python3 main.py if you have multiple versions installed. I ran the game on 5 different computers with different systems and it works fine.

aelmosalamy commented 5 years ago

Btw, I checked your game pythonRPG, looks pretty cool, but I noticed how you put everything in one file, This isn't good. If you want to follow professional coding practices, you should separate it into multiple distinctive files, with each file serving a specific function (Enemy class and its child in one file, one file for quotes, etc..) this way you can organize your project and make it more readable. Also I recommend having a look on this blog post with actually inspired me to start on ASCII Combat and gave me some solid ground for where to start from https://inventwithpython.com/blog/2014/12/11/making-a-text-adventure-game-with-the-cmd-and-textwrap-python-modules/

iamparkerm commented 5 years ago

Thanks. Will work on all that this weekend. I'm new to contributing to other projects on GitHub, but look forward contributing to yours. Feel free to make a PR to my GitHub so I can see what that looks like if you want?

iamparkerm commented 5 years ago

OK, works now. My computer was using python2 for some reason.

iamparkerm commented 5 years ago

Created a PR to fix the Readme instructions. Please merge. Thanks!

aelmosalamy commented 5 years ago

I will close this issue now!