search

aelve / guide

A workspace for research teams
https://guide.aelve.com
106 stars 10 forks source link

Fix ghc warnings (#181) #182

Closed sectore closed 7 years ago

sectore commented 7 years ago

It fixes ghc warnings as described in #181

In general: What about to have more restrict imports of modules to avoid shadowing variables? Another problem could be the Imports module to use it everywhere. With that we might import content we don't need in other modules, but we have to care about shadowing variables.

Anyway, if these warnings are not important we could change ghc warning options to prevent its output. But I would suggest that everyone focus more on all warnings with the goal to compile Guide w/o any warnings :)

neongreen commented 7 years ago

In general: What about to have more restrict imports of modules to avoid shadowing variables?

Well, sure, we can do that occasionally via qualified imports. I would still prefer things like view to always mean the view from lenses, though.