search

aelve / guide

A workspace for research teams
https://guide.aelve.com
106 stars 10 forks source link

#202 Add API endpoints #203

Closed sectore closed 7 years ago

sectore commented 7 years ago

Description: See https://github.com/aelve/guide/issues/202

Note: While fetching some (not all) categories we still have errors to parse json. For example: http://localhost:3333/category/haskell/v3stlvmj 

Error loading data: [JSONDecodingError]: "Generic json decoding failed: Expected a string: '[]'"

This is the same error as @neongreen reported few weeks ago here https://aelve.slack.com/archives/C3UQX6F45/p1502655419531200

~Because this error is not thrown by every category (for example http://localhost:3333/category/haskell/lbbp2xa6 works w/o any issues) it seems to be an issue by data stored in backend and not an issue by this PR.~

~So I would suggest to check / fix this json issue with another task.~

Update (Sept 10th):

neongreen commented 7 years ago

Tests are broken now:

Failures:
  tests/Selenium.hs:410: 
  1) items using chrome, item properties, name, links to Hackage
     if the name is originally a package name
       (://) (Element "227") (ByLinkText "Hackage") wasn't found on the page
sectore commented 7 years ago

@neongreen Can you see why https://github.com/aelve/guide/pull/203/commits/7d6aa64d4bd3c686fcc41e85b90af824f0cd43ee is breaking the tests? I have to dive more into core code to find it out... ~Anyway, I will check it later today (or tomorrow) again.~ Ok, I have pushed a fix (hopefully) :arrow_down: .