Closed vojiranto closed 5 years ago
@willbasky this can be re-reviewed.
Since I pushed some unrelated changes here as well, here are descriptions for the new commits (except for ones that only add comments):
https://github.com/aelve/guide/pull/264/commits/503907fae86d3700c5af0370a69851ccbaa12af2 -- moves error logging into instance MonadError Guider and adds a logger for uncaught exceptions.
instance MonadError Guider
https://github.com/aelve/guide/pull/264/commits/6fbeab91736b1ce3739d847f32b437c87e81cc6a -- removes .ghci because it prevents the project from being loaded in GHCi.
.ghci
https://github.com/aelve/guide/pull/264/commits/fac5ef0ea245e7e21e73d918c74c3c71b4536475, https://github.com/aelve/guide/pull/264/commits/c0614a836651932be5e17ffed2d8fbd0d57d39ff -- changes log formatting (though we'll have to change it further, I looked at a big log and it's not pretty at all)
https://github.com/aelve/guide/pull/264/commits/960baedab527fc68f442c86acee91beaea31196d -- removes log levels like emergency, alert, etc because they are useless for us.
emergency
alert
https://github.com/aelve/guide/pull/264/commits/28f1bb7c5f6340c96618cd68d55f0db81e4f58bb, https://github.com/aelve/guide/pull/264/commits/b5b5b884a7a8ca62c5fe8e956df4509d894b3272 -- renames Guide.Logger.{Init,Methods} to Guide.Logger.{Run,Functions}, renames debugT and so on to more standard logDebug, and introduces name like Logger and LoggerT because Di and DiT are rather bad names.
Guide.Logger.{Init,Methods}
Guide.Logger.{Run,Functions}
debugT
logDebug
Logger
LoggerT
Di
DiT
https://github.com/aelve/guide/pull/264/commits/654d49f2162a926d5937f61bb160574416c37470 -- adds more logging (except for checkConflict because it seems to not be useful there, but maybe I'm wrong).
checkConflict
https://github.com/aelve/guide/pull/264/commits/1550ad956228ea830f5fbd664f974ae7ee46bbab -- removes GuiderServer because it was an extra name that wasn't contributing anything.
GuiderServer
https://github.com/aelve/guide/pull/264/commits/171e10545ecdff10813141fd5db41fa3df6b11e2 -- renames the Api module to ApiSpec to be consistent with other modules.
Api
ApiSpec
https://github.com/aelve/guide/pull/264/commits/416cad8603d6441b71bd81907207ec776ab8d957 -- removes the footer test because it breaks all the time and is not that useful.
@willbasky this can be re-reviewed.
Since I pushed some unrelated changes here as well, here are descriptions for the new commits (except for ones that only add comments):
https://github.com/aelve/guide/pull/264/commits/503907fae86d3700c5af0370a69851ccbaa12af2 -- moves error logging into
instance MonadError Guiderand adds a logger for uncaught exceptions.https://github.com/aelve/guide/pull/264/commits/6fbeab91736b1ce3739d847f32b437c87e81cc6a -- removes
.ghcibecause it prevents the project from being loaded in GHCi.https://github.com/aelve/guide/pull/264/commits/fac5ef0ea245e7e21e73d918c74c3c71b4536475, https://github.com/aelve/guide/pull/264/commits/c0614a836651932be5e17ffed2d8fbd0d57d39ff -- changes log formatting (though we'll have to change it further, I looked at a big log and it's not pretty at all)
https://github.com/aelve/guide/pull/264/commits/960baedab527fc68f442c86acee91beaea31196d -- removes log levels like
emergency,alert, etc because they are useless for us.https://github.com/aelve/guide/pull/264/commits/28f1bb7c5f6340c96618cd68d55f0db81e4f58bb, https://github.com/aelve/guide/pull/264/commits/b5b5b884a7a8ca62c5fe8e956df4509d894b3272 -- renames
Guide.Logger.{Init,Methods}toGuide.Logger.{Run,Functions}, renamesdebugTand so on to more standardlogDebug, and introduces name likeLoggerandLoggerTbecauseDiandDiTare rather bad names.https://github.com/aelve/guide/pull/264/commits/654d49f2162a926d5937f61bb160574416c37470 -- adds more logging (except for
checkConflictbecause it seems to not be useful there, but maybe I'm wrong).https://github.com/aelve/guide/pull/264/commits/1550ad956228ea830f5fbd664f974ae7ee46bbab -- removes
GuiderServerbecause it was an extra name that wasn't contributing anything.https://github.com/aelve/guide/pull/264/commits/171e10545ecdff10813141fd5db41fa3df6b11e2 -- renames the
Apimodule toApiSpecto be consistent with other modules.https://github.com/aelve/guide/pull/264/commits/416cad8603d6441b71bd81907207ec776ab8d957 -- removes the footer test because it breaks all the time and is not that useful.