aelve / guide

A workspace for research teams
https://guide.aelve.com
106 stars 10 forks source link

Add target _blank #398

Closed willbasky closed 5 years ago

willbasky commented 5 years ago

This change is Reviewable

willbasky commented 5 years ago

back/src/Guide/Markdown.hs, line 193 at r1 (raw file):


-- | Convert LINK to HTML_INLINE with 'target="blank"' attribute added.
linkToHtmlInline :: MD.Node -> MD.Node

Not sure it is enough pattern matching or there are other cases.

neongreen commented 5 years ago

Please merge when my suggestions are committed.

neongreen commented 5 years ago

Oops, it got merged by itself. I will apply the suggestions to develop.