Open sahoahfoa opened 7 years ago
When this is added it would be great to have a pounds and stones option for UK (+ Irish & Australian?) users as well as pounds only for American (+ Canadian?) users.
I have always thought of adding a "Settings panel" in the gui for this kind of features. Should not be a problem of converting this in the ui. I will add this as a feature request.
Any update on this?
I've implemented this in my fork at https://github.com/ribbons/Wii-Scale, so you can do: npm config set wii-scale:units lbs
or npm config set wii-scale:units stones
to select your favourite units.
Might be a few rough edges, so let me know if you hit any issues.
Perfect, ill keep this open since I want to add this to the ui.
Would be good to make this user-specific. So Mog can have kilograms, and their room-mate Ribbons can have lbs.
In my country, both are used, as well as 'Stones and Lbs'. Ideally all three should be supported.
I've implemented this in my fork at https://github.com/ribbons/Wii-Scale, so you can do:
npm config set wii-scale:units lbs
ornpm config set wii-scale:units stones
to select your favourite units.Might be a few rough edges, so let me know if you hit any issues.
I know it has been many years without activity, just tried this out.
npm config set wii-scale:units lbs does nothing, the web interface is still in KGS
npm config set wii-scale:units stones does change the interface to weight in stones, it says something like stones and lbs.
Anyone know anything I might be missing or can adjust to make it display output in lbs?
Thanks
@crimp42 Are you using the fork?
@crimp42 Are you using the fork?
Yes, I cloned https://github.com/ribbons/Wii-Scale
I confirmed the one I am using has the changes in Wii-Scale/web/public/source/scripts/filters.js
Thanks
Actually I got it to work.
I had to use: npm config set wii-scale:units lb
NOT
npm config set wii-scale:units lbs
Actually I got it to work.
I had to use: npm config set wii-scale:units lb
NOT
npm config set wii-scale:units lbs
Glad you managed to club it into submission. I think the issue is that the minified versions of the files I committed are out of sync with the source (and instructions) - I tried re-building them just now by running grunt and that seemed to do the trick. Certainly my implementation looks a bit unfinished at this distance so glad it is working okay for you :+1:
Actually I got it to work. I had to use: npm config set wii-scale:units lb NOT npm config set wii-scale:units lbs
Glad you managed to club it into submission. I think the issue is that the minified versions of the files I committed are out of sync with the source (and instructions) - I tried re-building them just now by running grunt and that seemed to do the trick. Certainly my implementation looks a bit unfinished at this distance so glad it is working okay for you 👍
Thanks for doing this fork!
Granted only 3 countries actually use imperial units it would be easier to interpret what my weight is if it was in pounds.