search

aelveborn / Wii-Scale

Turns your Wii Balance Board into a scale and presents your weight on a responsive website. Runs Linux and works on your Raspberry Pi.
http://aelveborn.github.io/Wii-Scale/
GNU General Public License v2.0
116 stars 27 forks source link

Front end graph stop drawing after a few months of stored data. #23

Closed Nauttor closed 6 years ago

Nauttor commented 7 years ago

I´m an intensive user of the system, my wife to be more concrete, and after a few months the graph stop drawing. It happened to me before and the only workaround it's to create a new user and start again but you lose all data.

@aelveborn can you check on the issue please?

Just for the record I attach below a screen capture of the issue.

screen shot 2017-06-21 at 19 14 40
sahoahfoa commented 6 years ago

Can you post your app-data.json file and any relevant nodejs logs? It'll help a lot in debugging this.

Nauttor commented 6 years ago

Sure, I'll upload it later today.

sahoahfoa commented 6 years ago

I think I have it figured out. I believe the graph is only showing the first 14 data points instead of the last 14. The for loop that builds the data set for the graph is fine but assumed the data points would be appended to the end of the list instead of the beginning. I'll submit a PR tomorrow evening to fix it.

Nauttor commented 6 years ago

Wow, that was fast sahoahfoa, thanks.

I'll test your patch in order to confirm your thoughts.

Regards.

ribbons commented 6 years ago

As @sahoahfoa's PR is closed but not merged, I've added a similar fix for this issue to my fork at https://github.com/ribbons/Wii-Scale so it doesn't get forgotten

aelveborn commented 6 years ago

Should have been merged to master now. Closing issue.

ribbons commented 6 years ago

Should have been merged to master now. Closing issue.

Sorry @aelveborn - I wasn't as clear as I should have been - the fix was on the master branch at my fork rather than the cpp backend branch, so this fix didn't get merged. I've raised PR #29 for it.

aelveborn commented 6 years ago

@ribbons oh I see, I merged your PR.