search

aelveborn / Wii-Scale

Turns your Wii Balance Board into a scale and presents your weight on a responsive website. Runs Linux and works on your Raspberry Pi.
http://aelveborn.github.io/Wii-Scale/
GNU General Public License v2.0
116 stars 27 forks source link

Export csv #37

Open sahoahfoa opened 5 years ago

sahoahfoa commented 5 years ago

I've added a download link that will export the current users data to a csv file as per #12.

mo-g commented 5 years ago

Again, same criticism - you've got a huge PR overreach and need to rebase against @aelveborn's Master.

Separate (minor) comment, the indenting in directives.js at line 112 is... throwing me quite a bit. I think I need to pull this up in a text editor to better understand, but at first glance it doesn't make a huge amount of sense to me.

But this is a really great piece of work, and thankyou for writing it. :)

sahoahfoa commented 5 years ago

Oops the indenting is due to my editor using spaces instead of tabs.

aelveborn commented 5 years ago

@sahoahfoa did you correct the indenting? Still looks wrong in the GitHub preview. I'm gonna test run this before I merge it. I think functions like export etc are advanced functionality and should be placed in some advanced settings section in the gui. Maybe I'll write some pretty ui to this functionality.

sahoahfoa commented 5 years ago

I agree and I think that's a fantastic idea. I've been wanting to create a settings area for awhile now, but I've never used Angular before so it's been difficult making sure what I do follows best practices.