fix: react fast refresh by reordering Vite React preamble script first - Githubissues

aem-vite / vite-aem-plugin

A proxy server and starter kit for using Vite with Adobe Experience Manager.

https://aemvite.dev/guide/front-end/vite-plugin/

Apache License 2.0

10 stars 2 forks source link

fix: react fast refresh by reordering Vite React preamble script first #11

Closed Tyler-Brenneman closed 4 months ago

Tyler-Brenneman commented 4 months ago

Description

Fix React fast refresh script injection

Fixes #10

Additional context

Reorder injection to avoid error

Uncaught Error: @vitejs/plugin-react can't detect preamble. Something is wrong. See https://github.com/vitejs/vite-plugin-react/pull/11#discussion_r430879201

What is the purpose of this pull request?

[x] Bug fix
[ ] New Feature
[ ] Documentation update
[ ] Other

Before submitting the PR, please make sure you do the following

[x] Read the Contributing Guidelines.
[x] Read the Pull Request Process and follow the Commit Convention.
[x] Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
[x] Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
[x] Ideally, include relevant tests that fail without this PR but pass with it.

cshawaus commented 4 months ago

@Tyler-Brenneman Thanks for this fix, surprised it never came up during my test, but good to see it fixed nonetheless.