search

aemsites / 888de

Apache License 2.0
0 stars 0 forks source link

Options from hamburger menu opens in the same tab unlike the original site where it opens on new tab #190

Closed ByronA-888WHG closed 2 months ago

ByronA-888WHG commented 3 months ago

Hello @helms-charity, Please look at the issue below.

  1. Options from hamburger menu opens in the same tab unlike the original site where it opens on new tab Note: Only "Aktionen" should open in the same tab

Step to Replicate

  1. Open Hamburger menu
  2. Click any menu (Only "Aktionen" should open in the same tab) 2024-04-04_17-58-43

Thank you!

helms-charity commented 3 months ago

Defect: It seems the external links are not programmatically getting target="blank" applied when outside of <main>.

The functions buildLinks and decorateExternalLinks on scripts.js:50 and scripts.js:119 both need to extend to the document, and maybe these can be combined?

dave-fink commented 3 months ago

@ByronA-888WHG This has been resolved. Please retest.

ByronA-888WHG commented 3 months ago

Hello @dave-fink, Upon retesting, I verified that the issue is fixed. But I've noticed that the drop-down menu closes once the link is clicked. This does not happen with the original page. Is this to be expected or should I create another bug for this? Thank you!

https://github.com/aemsites/888de/assets/165295931/102fae32-e662-450a-8415-38659e1a13b3

ByronA-888WHG commented 2 months ago

Hello, As per @rafim888 this is OK and can be closed now. Thanks!