aemsites / 888de

Apache License 2.0
0 stars 0 forks source link

placeholder above 888-main.js #218

Closed helms-charity closed 2 months ago

helms-charity commented 2 months ago

From Rafi: The funnel data script is placed by default before the first script that comes from the CMS. it's injected first thing on the page head so that the sCut object is initialized as soon as possible so that any script that wants to use it will have it ready by then. (is aem.js using the sCut object in it ??) you can change the location of this script by adding the following comment on the page head:

the script will be placed after this comment.

Ticket/Issue number(s)

Fix #217

Test URLs

Testing instructions

after doing this change @Nave Naim it is important to test all the places that touch the sCut object, the logic that passes the funnel parameters from the current site to other sites. so @Charity Helms

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [e2d9ed5](https://github.com/aemsites/888de/commit/e2d9ed5d45d998ba7db1884899923cb439d5502d) :white_check_mark: (latest)
aem-code-sync[bot] commented 2 months ago
Page Scores Audits
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS