aemsites / ancestry

Apache License 2.0
0 stars 0 forks source link

prelim: implement Modal (youtube) #61

Closed FentPams closed 2 weeks ago

FentPams commented 3 weeks ago

Implement youtube video in modal

The embed block is for temporarily accommodating youtube video trigger button (not completed yet), the youtube modal could be compatible with any text/button has correct youtube link.

Screenshot 2024-10-21 at 4 38 48 PM

Fix #49

Test URLs:

aem-code-sync[bot] commented 3 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [f50a69b](https://github.com/aemsites/ancestry/commit/f50a69b530dfee588a01c4127023bed9aad111b1) :white_check_mark: (latest) * [badfb25](https://github.com/aemsites/ancestry/commit/badfb253535a77d4303d7453da341d5fa6f7c39d) :white_check_mark: * [8b2ea33](https://github.com/aemsites/ancestry/commit/8b2ea33ba3dc7b15bead12f167ddf835e8438780) :white_check_mark: * [1696b52](https://github.com/aemsites/ancestry/commit/1696b527706d032e9ddaf0d0fd9f12107fa67f8f) :white_check_mark: * [abd8040](https://github.com/aemsites/ancestry/commit/abd80403bb7428d1687d369d80ae63c67873bbff) :white_check_mark: * [8c9d283](https://github.com/aemsites/ancestry/commit/8c9d2836291bc351119beea9470dbfdf69b49819) :white_check_mark: * [ea69abf](https://github.com/aemsites/ancestry/commit/ea69abf67f1a5cc2e7827caabb4e0dccf992ddae) :white_check_mark: * [986c585](https://github.com/aemsites/ancestry/commit/986c5850a9de2522d7ed57258837897cafd9541b) :white_check_mark:
aem-code-sync[bot] commented 3 weeks ago
Page Scores Audits Google
:iphone: /drafts/xfeng/embed PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /drafts/xfeng/embed PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
dkuntze commented 2 weeks ago

My only concern is that this can sometimes add to LCP if its not in a modal. Here's a good impl to mitigate that: https://github.com/hlxsites/petplace/tree/main/blocks/embed

FentPams commented 2 weeks ago

My only concern is that this can sometimes add to LCP if its not in a modal. Here's a good impl to mitigate that: https://github.com/hlxsites/petplace/tree/main/blocks/embed

@dkuntze They were doing the lite-youtube thing in petplace is because they have many youtube videos are auto playing in the page. While we didn't have such thing, our youtube video is inside a modal and will only be triggered when user has interaction with it. I guess it will not have much affect on LCP. But if it does, I will adjust it. Thank you for pointing that out :)

dkuntze commented 2 weeks ago

Yeah, it's just for future use. Just in case.