Closed FentPams closed 2 weeks ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | ||
---|---|---|---|---|
:iphone: | /drafts/xfeng/embed | |||
:desktop_computer: | /drafts/xfeng/embed |
My only concern is that this can sometimes add to LCP if its not in a modal. Here's a good impl to mitigate that: https://github.com/hlxsites/petplace/tree/main/blocks/embed
My only concern is that this can sometimes add to LCP if its not in a modal. Here's a good impl to mitigate that: https://github.com/hlxsites/petplace/tree/main/blocks/embed
@dkuntze They were doing the lite-youtube thing in petplace is because they have many youtube videos are auto playing in the page. While we didn't have such thing, our youtube video is inside a modal and will only be triggered when user has interaction with it. I guess it will not have much affect on LCP. But if it does, I will adjust it. Thank you for pointing that out :)
Yeah, it's just for future use. Just in case.
Implement youtube video in modal
The embed block is for temporarily accommodating youtube video trigger button (not completed yet), the youtube modal could be compatible with any text/button has correct youtube link.
Fix #49
Test URLs: