search

aemsites / audi

Apache License 2.0
1 stars 0 forks source link

Hero #18

Closed markusbulla closed 7 months ago

markusbulla commented 7 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #4

Draft URL:

Test URLs:

aem-code-sync[bot] commented 7 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [79d44a3](https://github.com/aemsites/audi/commit/79d44a376f0dc8fbd59ed02cce17f1be7547de8b) :white_check_mark: (latest) * [9589ef0](https://github.com/aemsites/audi/commit/9589ef0b6a26c2cda9940dec96437cb34a52263b) :white_check_mark: * [ae14d46](https://github.com/aemsites/audi/commit/ae14d46dbd1a639ca8856e24304b19528602ba98) :white_check_mark: * [2225a01](https://github.com/aemsites/audi/commit/2225a018ce532f683daa681977b965786274b7df) :white_check_mark: * [4ff5f21](https://github.com/aemsites/audi/commit/4ff5f216db47dc639ecea5469f62a834bf758fe3) :white_check_mark: * [c841e4e](https://github.com/aemsites/audi/commit/c841e4e50817a0d44e0b4bd64fc742e2a31b7a9d) :white_check_mark: * [7a95832](https://github.com/aemsites/audi/commit/7a958325faf33caab18f1a79c483fab3d621019c) :white_check_mark: * [80f9039](https://github.com/aemsites/audi/commit/80f9039089a747458d34e667effa6dcf4d5d31a0) :white_check_mark: * [dd452c5](https://github.com/aemsites/audi/commit/dd452c58242525bfaac6a7a23fbb64d72d61eef6) :white_check_mark: * [a6d4ae5](https://github.com/aemsites/audi/commit/a6d4ae5d975fc41bb10f290a67581ecc4213e968) :white_check_mark: * [bccfc88](https://github.com/aemsites/audi/commit/bccfc886e1a6033591f1761d8abcbfb6f00e8bd3) :white_check_mark: * [87bbbd5](https://github.com/aemsites/audi/commit/87bbbd559fe9f06a87c95879079e2277d47e2399) :white_check_mark: * [0d830e8](https://github.com/aemsites/audi/commit/0d830e898b6086132ed594aa2e6c97ba0348ea01) :white_check_mark: * [a15def8](https://github.com/aemsites/audi/commit/a15def88a44c4abc2738b6d5b6f13c78ed7c2415) :white_check_mark: * [da86618](https://github.com/aemsites/audi/commit/da866185e8ba7ab8e3ba8ab594ea9c86a13f32f2) :white_check_mark: * [8b89470](https://github.com/aemsites/audi/commit/8b89470b2cba0f4873f43b701e8d469feb39bc4e) :white_check_mark: * [bf0f082](https://github.com/aemsites/audi/commit/bf0f0827437dd8d815488c3214d65fe1c6ccaaea) :white_check_mark: * [84ba3f1](https://github.com/aemsites/audi/commit/84ba3f14e01a4bf6af0ed848d566ae3ce1d0f37a) :white_check_mark: * [33e2d5c](https://github.com/aemsites/audi/commit/33e2d5ccd3ed7e54859eb8105a26c1dd60895c66) :white_check_mark: * [e836b2c](https://github.com/aemsites/audi/commit/e836b2c36a9e7cfc0c436ffcf70bb785b2109b0b) :white_check_mark: * [8e724b8](https://github.com/aemsites/audi/commit/8e724b87ae1b69fd625a5ff41691229782f83162) :white_check_mark: * [69d443c](https://github.com/aemsites/audi/commit/69d443c0b50f030e2124da192eb37aa2c40c3977) :white_check_mark:
aem-code-sync[bot] commented 7 months ago
Page Scores Audits Google
/uk/web/en/drafts/hero PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/uk/web/en/used-cars PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
markusbulla commented 7 months ago

First draft PR with default hero block for 3 different view ports (<768; 768-1023; >=1024). Will continue work on the two variations of the hero block.

amol-anand commented 7 months ago

@markusbulla please don't add any package.json or package-lock changes to your PRs. you can safely ignore them.

LucaNerlich commented 7 months ago

image

hero (variation1) - text content is not centered on desktop

markusbulla commented 7 months ago

@markusbulla please don't add any package.json or package-lock changes to your PRs. you can safely ignore them.

Changes to package.json and package-lock have been removed. 

* in general, the hero image is way too large
* the buttons are not clickable on desktop width

These two points have been resolved.