aemsites / esri

Apache License 2.0
1 stars 1 forks source link

Spike - Import of class names #123

Closed anu13297 closed 3 weeks ago

anu13297 commented 1 month ago

Can we carry over the class names on div's when importing pages so it helps to style them?

alexcarol commented 1 month ago

That's not really possible, we can carry over class names on blocks and sections, but not generically for everything. We also agreed with @tim-white-esri that we'd try to simplify as much as possible and avoid bringing unnecessary class names (e.g. if a block is always used with a certain class we don't need to add the class)

alexcarol commented 1 month ago

One example that we've applied is with theming, in many cases blocks have "dark mode" applied directly, but for the import we have a list of pages with "dark" or "light" mode, so that we don't need to repeat that for each block (though that's still possible to apply ad-hoc when needed)

alexcarol commented 3 weeks ago

Modes are imported