search

aemsites / esri

Apache License 2.0
1 stars 1 forks source link

Elastic large content stack #124

Closed hanem100k closed 1 month ago

hanem100k commented 1 month ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [5a50dba](https://github.com/aemsites/esri/commit/5a50dbaba73561dd1078e9cbf1f305965644e93d) :white_check_mark: (latest) * [0174679](https://github.com/aemsites/esri/commit/0174679c5ac671a8fe3b1bc1052a07fa2086e465) :white_check_mark: * [f085d6e](https://github.com/aemsites/esri/commit/f085d6eff159051041253d960df725cb2668f336) :white_check_mark: * [193d71e](https://github.com/aemsites/esri/commit/193d71efc4fba5fd7c5ceff8dd42821576e983c4) :white_check_mark: * [4d3d4fb](https://github.com/aemsites/esri/commit/4d3d4fbc9a0be4896e7e8de13ddca4aeecb94572) :white_check_mark: * [84aaed8](https://github.com/aemsites/esri/commit/84aaed8eee85cf693a850c2880403ef4bfa5e635) :white_check_mark: * [4f38ef4](https://github.com/aemsites/esri/commit/4f38ef43b3dd4cda4011fcb2d0950a04ee76da75) :white_check_mark: * [72d1c51](https://github.com/aemsites/esri/commit/72d1c51ae45d7137295001d58fdf61343ab63057) :white_check_mark: * [7a9ebda](https://github.com/aemsites/esri/commit/7a9ebdac6632adc09cc464af3aab95a52add0a6a) :white_check_mark: * [06cf3cc](https://github.com/aemsites/esri/commit/06cf3cc31808a4b23f5649061162d146acf2dcf8) :white_check_mark: * [dca2f54](https://github.com/aemsites/esri/commit/dca2f54e24931020a4a12c8250627d278ae98ed1) :white_check_mark: * [b741058](https://github.com/aemsites/esri/commit/b741058f762032e8f1222b3e5f37a028a944c7eb) :white_check_mark: * [0718b7d](https://github.com/aemsites/esri/commit/0718b7db0cbde2d2aa8f5e4752033317a2e50fc8) :white_check_mark: * [5b13c07](https://github.com/aemsites/esri/commit/5b13c071c05c3bafc4d131aa8acf9980abcb63e1) :white_check_mark: * [69941ed](https://github.com/aemsites/esri/commit/69941edc1d0368f2be5cfd55347c1e5c8f7b5826) :white_check_mark: * [3d84e51](https://github.com/aemsites/esri/commit/3d84e51f757150a1c01b99b0f2ad96df802c38f3) :white_check_mark: * [fc0dfe0](https://github.com/aemsites/esri/commit/fc0dfe0493fc2142eb54cdfa8114432e98e2bca8) :white_check_mark: * [a0291bc](https://github.com/aemsites/esri/commit/a0291bcc702ad470496be91b5b531ee81394570e) :white_check_mark: * [4426fc7](https://github.com/aemsites/esri/commit/4426fc77549335673456f8d5ec8967b92e66b201) :white_check_mark: * [e2cf29c](https://github.com/aemsites/esri/commit/e2cf29cb3005c1c7731db44de4947cc016105102) :white_check_mark: * [a4c9221](https://github.com/aemsites/esri/commit/a4c92217fbf7975629a3dad9defce05d2933f5b5) :white_check_mark: * [619735e](https://github.com/aemsites/esri/commit/619735ea4b14ddad4ee515fb80a41dfd5ff5e546) :white_check_mark: * [7155239](https://github.com/aemsites/esri/commit/7155239410d6fd20168f3a2084bd72725d5271f6) :white_check_mark: * [440ee26](https://github.com/aemsites/esri/commit/440ee26a0385c17ff7ad52396ff8af418cc8affe) :white_check_mark: * [929cb5a](https://github.com/aemsites/esri/commit/929cb5ac941c02577dc446e6f352455ab393e633) :white_check_mark: * [e95c50a](https://github.com/aemsites/esri/commit/e95c50adc47f0506ab666ffa553394756e4622fb) :white_check_mark: * [201ea05](https://github.com/aemsites/esri/commit/201ea052264957a5998c0c53814e0388b1efab55) :white_check_mark: * [20801c6](https://github.com/aemsites/esri/commit/20801c66ba3f9256b9049c7fd34458f15d44f2b2) :white_check_mark: * [12c6194](https://github.com/aemsites/esri/commit/12c619426f0be41a5d540de0d4d4af12b977e9c9) :white_check_mark: * [e755940](https://github.com/aemsites/esri/commit/e7559401d79a720f75a22a9792e688f3ffda5562) :white_check_mark:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
:iphone: /en-us/about/about-esri/americas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/about/about-esri/americas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
alexcarol commented 1 month ago

The hover color doesn't match: Live site: image

Branch: image

hanem100k commented 1 month ago

The hover color doesn't match: Live site: image

Branch: image

Fixed. thanks

vladciocoiu commented 1 month ago

The layout shouldn't look like this on mobile:

image

There should only be 1 column:

image
hanem100k commented 1 month ago

The layout shouldn't look like this on mobile: image

There should only be 1 column: image

Thanks, did probably change media queries back and forth and didnt test again. Fixing it now.

alexcarol commented 1 month ago

I've also seen that this is used in at least one more page: https://www.esri.com/en-us/capabilities/indoor-gis/capabilities/space-planning-reservation, can you change the name to "Elastic content strip" instead? (as that's the original name and it's way more generic)

alexcarol commented 1 month ago

For now i've seen these two pages containing the block, which i'm in the process of uploading: