Closed twhite313 closed 1 month ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
@alexcarol not sure if its the best place to add it, but I have alternate langauges links being added to the head, which enables the language switcher. (The icon is misaligned for some reason, but that is for another task.)
I can't get past some of the linter errors. One makes no sense: it says splitPattern isn't used, but it clearly is 4 lines later. I tried modifying some of the other issues but it just ends up breaking my code.
@alexcarol not sure if its the best place to add it, but I have alternate langauges links being added to the head, which enables the language switcher. (The icon is misaligned for some reason, but that is for another task.)
I can't get past some of the linter errors. One makes no sense: it says splitPattern isn't used, but it clearly is 4 lines later. I tried modifying some of the other issues but it just ends up breaking my code.
I don't see "splitPattern" used anywhere, are you looking for it in the diff or in your editor? (in case there's changes that might not be pushed). Can you share a link to the line where it's used?
@twhite313 here's a suggested change for your PR: https://github.com/aemsites/esri/pull/135 Feel free to use it or change as you need
@alexcarol not sure if its the best place to add it, but I have alternate langauges links being added to the head, which enables the language switcher. (The icon is misaligned for some reason, but that is for another task.) I can't get past some of the linter errors. One makes no sense: it says splitPattern isn't used, but it clearly is 4 lines later. I tried modifying some of the other issues but it just ends up breaking my code.
I don't see "splitPattern" used anywhere, are you looking for it in the diff or in your editor? (in case there's changes that might not be pushed). Can you share a link to the line where it's used?
Well that's really weird. You and the linter couldn't see it. Literally there on line 60 and 64. Whatever; moving on.
Oh! The error changed. I see it is failing AFTER line 64 now. I was getting errors that it was never declared. Anyway... moving on.
@alexcarol not sure if its the best place to add it, but I have alternate langauges links being added to the head, which enables the language switcher. (The icon is misaligned for some reason, but that is for another task.) I can't get past some of the linter errors. One makes no sense: it says splitPattern isn't used, but it clearly is 4 lines later. I tried modifying some of the other issues but it just ends up breaking my code.
I don't see "splitPattern" used anywhere, are you looking for it in the diff or in your editor? (in case there's changes that might not be pushed). Can you share a link to the line where it's used?
Well that's really weird. You and the linter couldn't see it. Literally there on line 60 and 64. Whatever; moving on.
Oh! The error changed. I see it is failing AFTER line 64 now. I was getting errors that it was never declared. Anyway... moving on.
The issue was that it was assigned, but never read, so it's essentially not "used".
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #94
Test URLs: