aemsites / esri

Apache License 2.0
1 stars 1 forks source link

feat: update html lang and dir #161

Closed twhite313 closed 1 week ago

twhite313 commented 2 weeks ago

Update lang in html and update dir=[ltr | rtl] based on language.

Fix #153

Test URLs:

aem-code-sync[bot] commented 2 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [20be148](https://github.com/aemsites/esri/commit/20be1485176df226c4eddcc2f0ddf619dddd0f1c) :white_check_mark: (latest) * [e7fcbd6](https://github.com/aemsites/esri/commit/e7fcbd6068c6318f57d49ee8c0234b8e09efb113) :white_check_mark: * [cf89ccd](https://github.com/aemsites/esri/commit/cf89ccddab925cb613b293dbb296bb89ddf30b3c) :white_check_mark: * [6caa047](https://github.com/aemsites/esri/commit/6caa047a31d5b06b2cc5532969c5d641726d1cf9) :white_check_mark: * [979579e](https://github.com/aemsites/esri/commit/979579e0567642b78f814755d5108dfefdc3929a) :white_check_mark: * [42d63f2](https://github.com/aemsites/esri/commit/42d63f263332223d4b96652acc961fb33a9dfe05) :white_check_mark: * [cf3d528](https://github.com/aemsites/esri/commit/cf3d528553fb92bdab5ff3c4fc9582ff1f5b2281) :white_check_mark: * [7ec1fb1](https://github.com/aemsites/esri/commit/7ec1fb1453c0345c9c0c8a5599560fce68f556dc) :white_check_mark: * [2749d5c](https://github.com/aemsites/esri/commit/2749d5c685f2dc84b6ae85883e2dfd7ea21284ec) :white_check_mark: * [e3ff824](https://github.com/aemsites/esri/commit/e3ff824abf42493c892e181f07410fef2aea5880) :white_check_mark: * [3272866](https://github.com/aemsites/esri/commit/32728661c78495c4699673a7af218607c7905c94) :white_check_mark:
aem-code-sync[bot] commented 2 weeks ago
Page Scores Audits Google
:iphone: / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
twhite313 commented 2 weeks ago

@alexcarol added language switcher. Not sure why it's failing psi check.

twhite313 commented 2 weeks ago

@alexcarol updated with getMetadata. I also moved the function to separate it from the alternate headers code. Not sure it makes any difference, but it looked cleaner to me.

twhite313 commented 1 week ago

@alexcarol how's this?