search

aemsites / esri

Apache License 2.0
1 stars 1 forks source link

Implement map block #46

Open alexcarol opened 1 month ago

alexcarol commented 1 month ago

Original: https://www.esri.com/en-us/about/about-esri/americas Page: https://main--esri--aemsites.hlx.page/en-us/about/about-esri/americas

Another example: https://www.esri.com/en-us/about/about-esri/europe/overview

image

twhite313 commented 1 month ago

Maps should be added to current AEM pages using our Core Embed component. It creates an iframe:

<div class="experience-builder" style="width: ${properties.mapWidth @ context='html'}%; ">
    <iframe 
      role="application" 
      src="${properties.sourceURL}" 
      sandbox="allow-scripts allow-same-origin allow-forms allow-popups allow-popups-to-escape-sandbox" 
      allow="autoplay; geolocation;" 
      allowfullscreen="" 
      tabindex="0" 
      loading="lazy" 
      width="100%" 
      style="aspect-ratio: ${properties.aspectRatioDropdown @ context='html'};" 
      title="Experience builder application" 
      >
    </iframe>
  </div>

Authoring for existing Core Embed version allows:

title should be authorable, ideally with a default if not authored.

Working through some other samples...

twhite313 commented 1 month ago

Sample embeds: https://www.esri.com/en-us/sandbox/tim/maps?Asdfj

Last map is for https://www.esri.com/en-us/about/about-esri/europe/overview Embeddable URL: https://webapps-cdn.esri.com/Apps/regional-maps/europe.html

hanem100k commented 1 month ago

@tim-white-esri do you have by any chance a pointer for an embeddable URL for the other regions?

Tried variants for us, asia etc to no avial.

twhite313 commented 1 month ago

I will follow up with the developer; he was going to push all of them to the CDN. I'll get paths as soon as possible.

twhite313 commented 4 weeks ago

Two updates for the About pages with maps.

  1. We are going to push an update to the source pages. The copy leading into the maps is using old markup. We are converting that to the current standard. This will eliminate the need for the extra CSS I've seen in the pull requests

  2. The remaining maps are now hosted on a CDN: https://webapps-cdn.esri.com/Apps/regional-maps/mea.html https://webapps-cdn.esri.com/Apps/regional-maps/americas.html https://webapps-cdn.esri.com/Apps/regional-maps/asiapacific.html