aemsites / esri

Apache License 2.0
1 stars 1 forks source link

Nest tabs and tabs-cards components #71

Closed vladciocoiu closed 2 months ago

vladciocoiu commented 2 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #60

Test URLs:

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [eef043a](https://github.com/aemsites/esri/commit/eef043ad286e9ccb2044ef8652980e2d888dd989) :white_check_mark: (latest) * [75ed665](https://github.com/aemsites/esri/commit/75ed6655798d27269e072cef1227daa5b67fc169) :white_check_mark: * [ec726f2](https://github.com/aemsites/esri/commit/ec726f213a84280e32ace64081ebaf0e70218648) :white_check_mark: * [04d6fb1](https://github.com/aemsites/esri/commit/04d6fb12067c1bf50582d3e720671fbf8596932a) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/drafts/vciocoiu/tabs-cards PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
alexcarol commented 2 months ago

Where in the page should I be looking? I'm seeing this for "main": image

And this for your branch: image

vladciocoiu commented 2 months ago

Where in the page should I be looking? I'm seeing this for "main": image

And this for your branch: image

My branch shouldn’t look like that, can you please reload the content?

alexcarol commented 2 months ago

Where in the page should I be looking? I'm seeing this for "main": image And this for your branch: image

My branch shouldn’t look like that, can you please reload the content?

If I go to ".page" it does look like this instead, can you check the link you attached to the PR? Can you make sure what's in ".page" is published? image

vladciocoiu commented 2 months ago

Where in the page should I be looking? I'm seeing this for "main": image And this for your branch: image

My branch shouldn’t look like that, can you please reload the content?

If I go to ".page" it does look like this instead, can you check the link you attached to the PR? Can you make sure what's in ".page" is published? image

It should be working now