aemsites / esri

Apache License 2.0
1 stars 1 forks source link

Implement mosaic reveal block #80

Closed vladciocoiu closed 2 months ago

vladciocoiu commented 2 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #74

Test URLs:

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [31cf737](https://github.com/aemsites/esri/commit/31cf737bf483fc9de21d0facd1c2dc288cc77d8c) :white_check_mark: (latest) * [1280f3d](https://github.com/aemsites/esri/commit/1280f3d61638ebb01b5b64237a64d3f1682fbeec) :white_check_mark: * [63c1ad9](https://github.com/aemsites/esri/commit/63c1ad9f0aabc3648ecd31eca3ef7e048476639f) :white_check_mark: * [5278680](https://github.com/aemsites/esri/commit/52786804eadc1ca04e86f908877aa87195ea2469) :white_check_mark: * [9bfbf1b](https://github.com/aemsites/esri/commit/9bfbf1b4b4b2f0ba1e02724a7ce5bf8813198543) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/drafts/vciocoiu/mosaic-reveal PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
alexcarol commented 2 months ago

Regarding the animation, on the live site the element appears to be moving ("translateY") from the bottom, rather than scaling in the current implementation. Could you give a short to that approach?

vladciocoiu commented 2 months ago

Regarding the animation, on the live site the element appears to be moving ("translateY") from the bottom, rather than scaling in the current implementation. Could you give a short to that approach?

I animated the inset-block-start, since that was the approach in the live site. Thanks for pointing it out!