Closed hanem100k closed 2 months ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | ||
---|---|---|---|---|
M | /en-us/about/about-esri/americas | |||
D | /en-us/about/about-esri/americas |
Test URLs:
Can you please provide the correct URLs? I am not sure where I should look for the live site map.
Test URLs:
Can you please provide the correct URLs? I am not sure where I should look for the live site map.
Sure. I just had it in a draft.
Published it live here: https://map-block--esri--aemsites.hlx.live/en-us/about/about-esri/americas
I am not seeing anything on the website:
Opened up console and saw this:
Edit for clarification: I am looking here https://map-block--esri--aemsites.hlx.live/en-us/about/about-esri/americas
I am not seeing anything on the website:
Opened up console and saw this:
Edit for clarification: I am looking here https://map-block--esri--aemsites.hlx.live/en-us/about/about-esri/americas
Loads ok for me. Could you disable caching?
Loads ok for me. Could you disable caching?
Caching was disabled, also tried another browser. Still nothing.
There is this part of the map container that doesn't have a background image:
Also there is the same issue at the bottom.
You should adjust the paddings and margins probably.
The esri.com map displays Americas by default:
Yours is displaying Europe:
Also your map is smaller than the esri.com one on desktop.
Not sure whether these can be changed, so let me know if it's not possible right now.
Not sure whether these can be changed, so let me know if it's not possible right now.
We only have the europe map uploaded right now.
I'll change it to the US once that gets to us/uploaded.
Your map is smaller than the esri.com one on big screens (> 1500px) and bigger on tablets/ small desktops (860 -> 1500px)
@hanem100k we do not need to worry about the button and full screen mode for now. We will deal with that later, if it is still needed. Sorry -- I didn't notice that yesterday.
There is still some difference in the text section (your heading is bold, while the original one is not, and also you need a slightly bigger margin) -- most noticeable on mobile.
There is still some difference in the text section (your heading is bold, while the original one is not, and also you need a slightly bigger margin) -- most noticeable on mobile.
Not sure what is happening.
Just checked out if something broke it, however, that doesn't seem to be the case.
Screenshot is from: https://map-block--esri--aemsites.hlx.page/en-us/about/about-esri/americas
There is still some difference in the text section (your heading is bold, while the original one is not, and also you need a slightly bigger margin) -- most noticeable on mobile.
That is OK. The header/separator/text are actually wrong. We are correcting them on the current live site.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: