aemsites / esri

Apache License 2.0
1 stars 1 forks source link

Map section #91

Closed hanem100k closed 2 months ago

hanem100k commented 2 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [801aea5](https://github.com/aemsites/esri/commit/801aea5ca8ac11c5a604cc377b00264196a33acf) :white_check_mark: (latest) * [2dde4ef](https://github.com/aemsites/esri/commit/2dde4ef7a51d16dfc0d23d15ce71e378f9fd9f8e) :white_check_mark: * [7af05f5](https://github.com/aemsites/esri/commit/7af05f57510e392a505fb2671db285934296a7c9) :white_check_mark: * [341062d](https://github.com/aemsites/esri/commit/341062d2b37c9f39daf08936829edca44677c3fd) :white_check_mark: * [38763f6](https://github.com/aemsites/esri/commit/38763f6ef03d6dcf0d214ab3a24d1d85eeb0d424) :white_check_mark: * [4797f50](https://github.com/aemsites/esri/commit/4797f5015f14da2a4df6c072f61262b8b18804c6) :white_check_mark: * [8f02966](https://github.com/aemsites/esri/commit/8f02966e118005f5533fc82f327a175ff76a12ff) :white_check_mark: * [8ccbc3a](https://github.com/aemsites/esri/commit/8ccbc3a95c582841857acf7db8ecca1ad4e2142a) :white_check_mark: * [d8133f3](https://github.com/aemsites/esri/commit/d8133f3507e8cfa90997b560143ce25573274d1b) :white_check_mark: * [ea9e0f9](https://github.com/aemsites/esri/commit/ea9e0f9cd444e9b8d51b98d9b1695560b27010d2) :white_check_mark: * [5a3e5e3](https://github.com/aemsites/esri/commit/5a3e5e31724f23cc7e66ff58740dcd377ebcfde3) :white_check_mark: * [af8e581](https://github.com/aemsites/esri/commit/af8e581b659c67c9388569d2e0d1dd3d2462e356) :white_check_mark: * [334de69](https://github.com/aemsites/esri/commit/334de6967e445d126e635c134d00b179ae0872bf) :white_check_mark: * [ad3eff2](https://github.com/aemsites/esri/commit/ad3eff243c30b5d9069801417def2039ec3efa7b) :white_check_mark: * [3c9ee5b](https://github.com/aemsites/esri/commit/3c9ee5be0fc9a3c45babc9ff0eb9b539b86c37c2) :white_check_mark: * [ef1bcd0](https://github.com/aemsites/esri/commit/ef1bcd0e892c5ee9bb3df72f5448003498b2143a) :white_check_mark: * [3cca2d3](https://github.com/aemsites/esri/commit/3cca2d3eca75d9cd8de650acbc5d826bc2753c76) :white_check_mark: * [4fc22f6](https://github.com/aemsites/esri/commit/4fc22f6a5e7803923d82e54990eacdfdb480afab) :white_check_mark: * [fc046b8](https://github.com/aemsites/esri/commit/fc046b85936a549d9efbc34bfebbb5fa14739955) :white_check_mark: * [1fcce29](https://github.com/aemsites/esri/commit/1fcce29fa5a27775a3063720e9f67b65b3e00605) :white_check_mark: * [7a9e30c](https://github.com/aemsites/esri/commit/7a9e30c919ba9f1a7a9d30926877c5e60febcdc5) :white_check_mark: * [6efdd1d](https://github.com/aemsites/esri/commit/6efdd1d3db6fc103ef02235c7433cb26792449cc) :white_check_mark: * [87577c5](https://github.com/aemsites/esri/commit/87577c57f360cb0ded62675310d00d714563e789) :white_check_mark: * [efc3206](https://github.com/aemsites/esri/commit/efc320677a9bacdcd51942ec57c3f96c9135a727) :white_check_mark: * [54fe3c0](https://github.com/aemsites/esri/commit/54fe3c011a5465db6aeec020e7b7a991e27a08b0) :white_check_mark: * [4963fe4](https://github.com/aemsites/esri/commit/4963fe4f220532ea50cf4a0372850bd44a2fe299) :white_check_mark: * [d68e43b](https://github.com/aemsites/esri/commit/d68e43b00878a99b25d4be1848f88b83792550b1) :white_check_mark: * [d303ac5](https://github.com/aemsites/esri/commit/d303ac53a1d48518fc9f462c3977882449b28ecb) :white_check_mark: * [a507a3f](https://github.com/aemsites/esri/commit/a507a3f00db8b929e020ad4217dfd8c0b3378e94) :white_check_mark: * [e4cd23f](https://github.com/aemsites/esri/commit/e4cd23f304583f87bb174a09d07689de86eb9ebb) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
M /en-us/about/about-esri/americas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /en-us/about/about-esri/americas PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
vladciocoiu commented 2 months ago

Test URLs:

Can you please provide the correct URLs? I am not sure where I should look for the live site map.

hanem100k commented 2 months ago

Test URLs:

Can you please provide the correct URLs? I am not sure where I should look for the live site map.

Sure. I just had it in a draft.

Published it live here: https://map-block--esri--aemsites.hlx.live/en-us/about/about-esri/americas

vladciocoiu commented 2 months ago

I am not seeing anything on the website:

image

Opened up console and saw this:

image

Edit for clarification: I am looking here https://map-block--esri--aemsites.hlx.live/en-us/about/about-esri/americas

hanem100k commented 2 months ago

I am not seeing anything on the website: image

Opened up console and saw this: image

Edit for clarification: I am looking here https://map-block--esri--aemsites.hlx.live/en-us/about/about-esri/americas

Loads ok for me. Could you disable caching?

vladciocoiu commented 2 months ago

Loads ok for me. Could you disable caching?

Caching was disabled, also tried another browser. Still nothing.

vladciocoiu commented 2 months ago

There is this part of the map container that doesn't have a background image:

image

Also there is the same issue at the bottom.

You should adjust the paddings and margins probably.

vladciocoiu commented 2 months ago

The esri.com map displays Americas by default:

image

Yours is displaying Europe:

image

Also your map is smaller than the esri.com one on desktop.

Not sure whether these can be changed, so let me know if it's not possible right now.

hanem100k commented 2 months ago

Not sure whether these can be changed, so let me know if it's not possible right now.

We only have the europe map uploaded right now.

I'll change it to the US once that gets to us/uploaded.

vladciocoiu commented 2 months ago

Your map is smaller than the esri.com one on big screens (> 1500px) and bigger on tablets/ small desktops (860 -> 1500px)

twhite313 commented 2 months ago

@hanem100k we do not need to worry about the button and full screen mode for now. We will deal with that later, if it is still needed. Sorry -- I didn't notice that yesterday.

vladciocoiu commented 2 months ago

There is still some difference in the text section (your heading is bold, while the original one is not, and also you need a slightly bigger margin) -- most noticeable on mobile.

image image
hanem100k commented 2 months ago

There is still some difference in the text section (your heading is bold, while the original one is not, and also you need a slightly bigger margin) -- most noticeable on mobile.

image image

Not sure what is happening.

Just checked out if something broke it, however, that doesn't seem to be the case.

Screenshot is from: https://map-block--esri--aemsites.hlx.page/en-us/about/about-esri/americas

image
twhite313 commented 2 months ago

There is still some difference in the text section (your heading is bold, while the original one is not, and also you need a slightly bigger margin) -- most noticeable on mobile.

image image

That is OK. The header/separator/text are actually wrong. We are correcting them on the current live site.

twhite313 commented 2 months ago

All the maps are now available. https://webapps-cdn.esri.com/Apps/regional-maps/mea.html https://webapps-cdn.esri.com/Apps/regional-maps/asiapacific.html https://webapps-cdn.esri.com/Apps/regional-maps/americas.html