aemsites / hubblehomes-com

AEM Sites project for hubblehomes.com on Edge Delivery
Apache License 2.0
0 stars 0 forks source link

Fix resize issue when banner is dismissed. #242

Closed bhellema closed 3 months ago

bhellema commented 3 months ago

Fix #222

Test URLs:

Open the gallery, then dismiss the banner. The gallery should reposition itself.

aem-code-sync[bot] commented 3 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [1b1c710](https://github.com/aemsites/hubblehomes-com/commit/1b1c7101d9cf22c64c95f3e3f21dee3340dd15bf) :white_check_mark: (latest) * [7a81dd1](https://github.com/aemsites/hubblehomes-com/commit/7a81dd13cc0e93f01a44675482653f1c5b42f6c0) :white_check_mark:
aem-code-sync[bot] commented 3 months ago
Page Scores Audits Google
/new-homes/idaho/boise-metro/star/greendale-grove PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
codevoyage commented 3 months ago

In the previous version, the gallery button was not visible at all. The current version is fine.

However, the width of the banner being shorter than the width of the image is quite noticeable. Is this intentional?

bhellema commented 3 months ago

In the previous version, the gallery button was not visible at all. The current version is fine.

However, the width of the banner being shorter than the width of the image is quite noticeable. Is this intentional?

Yes, it is shorter. If you go full mobile you'll see it change for that layout which feels better.