Closed bhellema closed 2 months ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/ |
Just something to call out, for dataLayer in Nampa, seems that the pageType is "Search Results" https://www.hubblehomes.com/new-homes/idaho/boise-metro/nampa
dataLayer = [{
'pageType' : 'Search Results',
'city' : 'Nampa',
'state' : 'Idaho',
'region' : 'Boise Metro',
'community' : '',
'model' : '',
'spec' : ''
}];
where in this implementation it's home. First letters are also capitalized: https://issue-165--hubblehomes-com--aemsites.hlx.page/new-homes/idaho/boise-metro/nampa
dataLayer = [{
'pageType': 'home',
'city': 'nampa',
'state': 'idaho',
'region': 'boise metro',
'community': '',
'model': '',
'spec': ''
}];
Search Results
I saw that too and it made no sense that the page was called Search Results as it provides no context. I'm going to have to walk through the values they have with Nate and see what makes sense.
Good catch on the case differences. I intentionally toLowerCase everything for consistency as some of their results were all over the place. Again, I'll chat with Nate to see what he would like to see.
where in this implementation it's home. First letters are also capitalized: https://issue-165--hubblehomes-com--aemsites.hlx.page/new-homes/idaho/boise-metro/nampa
dataLayer = [{ 'pageType': 'home', 'city': 'nampa', 'state': 'idaho', 'region': 'boise metro', 'community': '', 'model': '', 'spec': '' }];
You did find a bug! The pageType should not be home for this example. I'll have to see why it's not resolving correctly.
Latest commit fixes issue with page type. Also fixed double dataLayer entry on 404 page.
Fix #165
Test URLs: