aemsites / learninga-z

Edge Delivery Service repo for learninga-z
Apache License 2.0
0 stars 0 forks source link

108 client side redirect for research only #109

Closed helms-charity closed 2 months ago

helms-charity commented 2 months ago

I don't know why fstab.yaml thinks I deleted a blank line. I don't think it will affect anything.

Fix # 108

Test URLs:

Testing criteria - what should the reviewer look for in your PR:

NOTE: If you have been redirected as expected, you will see H2 text "Specific product filter landing page" on the page. image

Otherwise, you are just on the /site/resources/research-and-efficacy.html page.

test1

https://108-redirecttags--learninga-z--aemsites.hlx.page/site/resources/research-and-efficacy?product=8602 should redirect to the correct path for product 8602's listing page, which is: https://108-redirecttags--learninga-z--aemsites.hlx.page/site/resources/research-and-efficacy/raz-plus

test 2

http://108-redirecttags--learninga-z--aemsites.hlx.page/site/resources/research-and-efficacy?product=8253&SortByAlpha=NewestFirst&SortByAuthor=-1 should redirect to a listing page, but keep the non-product query params attached (which are ignored): http://108-redirecttags--learninga-z--aemsites.hlx.page/site/resources/research-and-efficacy/foundationsa-z?SortByAlpha=NewestFirst&SortByAuthor=-1

test 3

http://108-redirecttags--learninga-z--aemsites.hlx.page/site/resources/research-and-efficacy?product=8253&SortByAlpha=NewestFirst&SortByAuthor=-1 should redirect but keep the non-product query params attached: http://108-redirecttags--learninga-z--aemsites.hlx.page/site/resources/research-and-efficacy/foundationsa-z?SortByAlpha=NewestFirst&SortByAuthor=-1

test 4

https://108-redirecttags--learninga-z--aemsites.hlx.page/site/resources/research-and-efficacy?product=1111 should not redirect at all, you will be taken to https://108-redirecttags--learninga-z--aemsites.hlx.page/site/resources/research-and-efficacy and the query param is just ignored.

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [ff960a5](https://github.com/aemsites/learninga-z/commit/ff960a5c80344ccea688f17c703060ea4d242c61) :white_check_mark: (latest) * [1cafc39](https://github.com/aemsites/learninga-z/commit/1cafc392906e413f65b0b6531679673cb5f448e8) :white_check_mark: * [2fb2022](https://github.com/aemsites/learninga-z/commit/2fb2022aa94a81e9ab4ae8dfb45957e641eb2100) :white_check_mark: * [2665a8d](https://github.com/aemsites/learninga-z/commit/2665a8d113150660b8b5d8032f077a6cfd998a23) :white_check_mark: * [2fcd605](https://github.com/aemsites/learninga-z/commit/2fcd605fd477924b40a357623b34fd92fbaf1985) :white_check_mark: * [efa0436](https://github.com/aemsites/learninga-z/commit/efa04367865383c5dc2e091a67097408032c89fd) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
M /site/resources/research-and-efficacy PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /site/resources/research-and-efficacy PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /site/resources/research-and-efficacy?product=1111 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /site/resources/research-and-efficacy?product=1111 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /site/resources/research-and-efficacy?product=8602 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /site/resources/research-and-efficacy?product=8602 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /site/resources/research-and-efficacy?product=8614 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /site/resources/research-and-efficacy?product=8614 PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
M /site/resources/research-and-efficacy/raz-plus PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
D /site/resources/research-and-efficacy/raz-plus PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI