aemsites / momentive

AEM Sites Edge Delivery project for Momentive.com
Apache License 2.0
0 stars 0 forks source link

Footer #31

Closed samuelopra closed 5 months ago

samuelopra commented 5 months ago

Fix #2

Test URLs:

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [c0baa3f](https://github.com/aemsites/momentive/commit/c0baa3f5e356b93f1f56d89d6f3eb80546f891e1) :white_check_mark: (latest) * [88e7133](https://github.com/aemsites/momentive/commit/88e7133bea8d5a6b890351d0a5ea9eebba67935d) :white_check_mark: * [7026216](https://github.com/aemsites/momentive/commit/7026216a55cc69a5d6df7bd89859dc524e562c4a) :white_check_mark: * [b42b96a](https://github.com/aemsites/momentive/commit/b42b96a0f3215a9a0b781c43cbcc1ca84098b0fb) :white_check_mark: * [afd8650](https://github.com/aemsites/momentive/commit/afd8650b4dc36b46a91c7c792b0dc39f5e529c4b) :white_check_mark: * [f057fda](https://github.com/aemsites/momentive/commit/f057fda6737790e37d0d6696539a376ed600d39f) :white_check_mark: * [fe01cd7](https://github.com/aemsites/momentive/commit/fe01cd7236ed3b69cb7ce99c85db09c3fb1c48a0) :white_check_mark: * [7cf1d67](https://github.com/aemsites/momentive/commit/7cf1d67d8ef1240c1a958f7a197dc8a669ea3395) :white_check_mark: * [8dfada7](https://github.com/aemsites/momentive/commit/8dfada737e783464aff5041e7cacc8c77c15024e) :white_check_mark: * [5900de9](https://github.com/aemsites/momentive/commit/5900de948cfd1aff7012ef534a2f5fa820910103) :white_check_mark: * [ddddbd2](https://github.com/aemsites/momentive/commit/ddddbd2508baf0e3e6c33dcf2aac65720124e131) :white_check_mark: * [2755cee](https://github.com/aemsites/momentive/commit/2755cee3ba776ae864669f1639bb86b31a510d94) :white_check_mark: * [f50330a](https://github.com/aemsites/momentive/commit/f50330a3dcfde2501aa1615d59e5656505411e48) :white_check_mark: * [3328a01](https://github.com/aemsites/momentive/commit/3328a019185c3c506996b586722b4762be0fd4bd) :white_check_mark: * [c8150b4](https://github.com/aemsites/momentive/commit/c8150b41b09471f040c96dd76ab4d55c089fb324) :white_check_mark:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
badvision commented 5 months ago

So far coming along pretty well, just make sure we're using the variables declared in style.css for uniformity. Also, important to keep in mind the default styles should be for the smallest (mobile) layout, and then anything needed for larger screen sizes should be declared with media selector (e.g. @media (width>=900px), etc) -- there's a lot of examples of this in the styles.css and other blocks already if you need to look at those for ideas. left-rail does a lot of funky stuff to deal with different behaviors in mobile vs desktop, but hopefully we don't have to do that kind of thing too much.