aemsites / momentive

AEM Sites Edge Delivery project for Momentive.com
Apache License 2.0
0 stars 0 forks source link

Implementing header block #39

Closed anuj-adobe closed 5 months ago

anuj-adobe commented 5 months ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #1

Test URLs:

Authoring doc: https://adobe.sharepoint.com/:w:/r/sites/HelixProjects/_layouts/15/Doc.aspx?sourcedoc=%7B64F34982-F5F0-4C33-8190-6688DCF8C489%7D&file=nav.docx&action=default&mobileredirect=true

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [c944b57](https://github.com/aemsites/momentive/commit/c944b571981a08bcbdf31f7dfb4f4e0e1ff7d4df) :white_check_mark: (latest) * [6682175](https://github.com/aemsites/momentive/commit/668217551135b099563a5e7c2ef9973cf5966d7a) :white_check_mark: * [848cce6](https://github.com/aemsites/momentive/commit/848cce6b8a112767543310a77cf01ec75c089ca0) :white_check_mark: * [35fabea](https://github.com/aemsites/momentive/commit/35fabeafb8d0cb09ae7f364eced89f2fbcf7e012) :white_check_mark: * [5303ad5](https://github.com/aemsites/momentive/commit/5303ad53cd21d999bd9d262bfe3ab344adccf833) :white_check_mark: * [21b9d0b](https://github.com/aemsites/momentive/commit/21b9d0b9c2ba84afc3074a18942f6e0f049dfa1a) :white_check_mark: * [6070da5](https://github.com/aemsites/momentive/commit/6070da56d8f979acc9cb6c88261f293c2dfa5ef9) :white_check_mark: * [5d90fb0](https://github.com/aemsites/momentive/commit/5d90fb026da8df22a7a098aca2d0e6f62daa2f0b) :white_check_mark: * [9823804](https://github.com/aemsites/momentive/commit/982380464e1aab06271b3e36459b2a146cb32876) :white_check_mark: * [8c21bb3](https://github.com/aemsites/momentive/commit/8c21bb3b4ccfa47a6881c33581e543ba24a5ec96) :white_check_mark: * [94148ef](https://github.com/aemsites/momentive/commit/94148ef7acbc37b1864de81dd320808feb43b407) :white_check_mark: * [a47fa81](https://github.com/aemsites/momentive/commit/a47fa814bb5aa4897badfcc7c27b5c7adf4358dd) :white_check_mark: * [1e35fef](https://github.com/aemsites/momentive/commit/1e35fef0cfbadc97d054a6362ad501cbac24b09f) :white_check_mark:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
anuj-adobe commented 5 months ago

@badvision Thank you for the review. I've updated the code -

  1. Used placeholders for the strings
  2. Also, used createElement() from /scripts/aem.js, enhancing readability.
  3. Fixed failing build due to linting errors