aemsites / momentive

AEM Sites Edge Delivery project for Momentive.com
Apache License 2.0
0 stars 0 forks source link

Columns Block #46

Closed badvision closed 5 months ago

badvision commented 5 months ago

We need a columns block which supports variants for different combinations of column/layout.

1) The block needs to support 2, 3 or 4 columns 2) The different layouts are:

Mobile requirements: For 2 and 3 columns, the columns should just stack vertically. For 4 columns, it should stack vertically with the left two columns on top and the right two columns on the bottom.

Example pages:

Cols Split Example 1 Example 2
2 33/66 https://www.momentive.com/en-us/about https://www.momentive.jp/content/momentive/jp/ja/company/company1.html
2 66/33 https://www.momentive.com/en-us/about/careers https://www.momentive.com/en-us/about
2 50/50 https://www.momentive.com/en-us/about
4 25/25/25/25 https://www.momentive.com/en-us/about
3 33/33/33 https://www.momentive.com/en-us/about/careers
anuj-adobe commented 5 months ago

I am using default column block in header block as well. Please make sure, the implementation support that as well. Used in -

  1. secondary navigation when hover on "+PRODUCTS" in desktop view.
  2. secondary navigation when hover on "+ORDER PRODUCTS" in desktop view.
  3. secondary navigation when click on "+ORDER PRODUCTS" in mobile view.
anuraggupta228 commented 5 months ago

Noted!, however I don't think we should be making any changes in OOTB block (for eg-> "Column" here) and more or less, I'll be introducing a new block (probably via name- "Column-Customised") and there on the basis of what variant the block gets call for, i'll be internally creating Column block like [1] with target variant and will create styling specifc to that variant. Do let me know if that doesn't makes sense.

[1]: var columnExtended = buildBlock('Column', {..Variant-data}) decorateBlock(columnExtended); loadBlock(columnExtended);