aemsites / piramal

Apache License 2.0
0 stars 0 forks source link

Issue 1: Default global content styling #20

Closed msagolj closed 1 month ago

msagolj commented 2 months ago

Fix #1

Test URLs:

aem-code-sync[bot] commented 2 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [6a1e31c](https://github.com/aemsites/piramal/commit/6a1e31c2c0bc753290dd87b8f17f469b32715fb1) :white_check_mark: (latest) * [91b60ae](https://github.com/aemsites/piramal/commit/91b60ae83d9184dc6fb204ed64898b1fadfaa820) :white_check_mark: * [455e075](https://github.com/aemsites/piramal/commit/455e075ebadc7fb1e155cd0775265fcdc0b8c74c) :white_check_mark: * [1c7eccd](https://github.com/aemsites/piramal/commit/1c7eccdd020958b69d890ef4888f609844396f14) :white_check_mark: * [60a0b0e](https://github.com/aemsites/piramal/commit/60a0b0e33988e9f423e2080dd21a54419ceb1e0f) :white_check_mark:
aem-code-sync[bot] commented 2 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
/mirko-test-page-styles PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
asthabh23 commented 2 months ago

Also, @msagolj as per : https://pagespeed.web.dev/analysis/https-issue-1--piramal--aemsites-hlx-page/2oootukycw?utm_source=psi&utm_medium=redirect&form_factor=mobile

there is an accessibility issue coming up around the sequence of headings (h3 -> h1 -> h4) - so levels are getting skipped. This needs to be updated to maintain the sequence.(highlighted parts in DOM below)

image
msagolj commented 1 month ago

Also, @msagolj as per : https://pagespeed.web.dev/analysis/https-issue-1--piramal--aemsites-hlx-page/2oootukycw?utm_source=psi&utm_medium=redirect&form_factor=mobile

there is an accessibility issue coming up around the sequence of headings (h3 -> h1 -> h4) - so levels are getting skipped. This needs to be updated to maintain the sequence.(highlighted parts in DOM below) image

@asthabh23 these are all headings where the H level can be edited by the author. h3 -> h1 should be ok, h1 -> h4 are titles so they can be changed. In their original site they don't see the issue because because the h4 is a div , so its on them to decide what supposed to be a title or just text.

In general their site is inconsistent whith using

or for titles e.g. 'Happy Customers ' is an H2 while 'Primal Since 1980' is a styled DIV