Closed mind-adobe closed 1 month ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/ |
still needs a padding fix for the section
@asthabh23
still needs a padding fix for the section
Should I also style the sections when creating the blocks? Also on their site, there are some "confetti" svgs for this block. Should I add them or are they unnecessary?
@mind-adobe yes, we need to add them! I was about to mention that
For section padding - I will create a separate issue then so it can be taken care of in one shot here is the new issue: https://github.com/aemsites/piramal/issues/29
@mind-adobe , please see and address the issues under accessibility: https://pagespeed.web.dev/analysis/https-10-homepage-testimonials-block--piramal--aemsites-hlx-page/926ft22tc1?utm_source=psi&utm_medium=redirect&form_factor=mobile
this gets highlighted in SEO as well
@mind-adobe , please see and address the issues under accessibility: https://pagespeed.web.dev/analysis/https-10-homepage-testimonials-block--piramal--aemsites-hlx-page/926ft22tc1?utm_source=psi&utm_medium=redirect&form_factor=mobile
this gets highlighted in SEO as well
Fixed it, should be good now
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #10
Test URLs: