aemsites / piramal

Apache License 2.0
0 stars 0 forks source link

10 homepage testimonials block #27

Closed mind-adobe closed 1 month ago

mind-adobe commented 1 month ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #10

Test URLs:

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [74c572b](https://github.com/aemsites/piramal/commit/74c572b1ea67aae638b50d8dd5eb40b84e34d325) :white_check_mark: (latest) * [216b227](https://github.com/aemsites/piramal/commit/216b2272a1c4f622fb800ebfa1281ba78ae0ac29) :white_check_mark: * [ade424b](https://github.com/aemsites/piramal/commit/ade424b4dc85aefdc2190018c072931835bedce5) :white_check_mark: * [6bbbffc](https://github.com/aemsites/piramal/commit/6bbbffc8b2ecda013a8e0cd8e189e007beb80be4) :white_check_mark: * [13882dd](https://github.com/aemsites/piramal/commit/13882dd4e35376b49106ced8bbddb47eaff5cbb2) :white_check_mark: * [728d9c0](https://github.com/aemsites/piramal/commit/728d9c0cc7832242d022921a4f1550e758127447) :white_check_mark: * [91ba869](https://github.com/aemsites/piramal/commit/91ba869fbf4cd0e8c1cece401e098d630037b254) :white_check_mark: * [b7e391a](https://github.com/aemsites/piramal/commit/b7e391ab5c36a0a3e53f13534add06e210a719db) :white_check_mark: * [a517045](https://github.com/aemsites/piramal/commit/a517045f21e9836df876036e311fc344b7d2eff6) :white_check_mark: * [c7602b1](https://github.com/aemsites/piramal/commit/c7602b19e22554ef739741f146cdc70fbeb1e66a) :white_check_mark: * [ca65711](https://github.com/aemsites/piramal/commit/ca6571189ba6a1365c7deb066d9052330dd91326) :white_check_mark: * [0b29e91](https://github.com/aemsites/piramal/commit/0b29e91eed3fe863ea906d45c008cca3b059cd5b) :white_check_mark: * [b132ebf](https://github.com/aemsites/piramal/commit/b132ebf6d41a211aa5a6df7b2910f82041c1f409) :white_check_mark:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
asthabh23 commented 1 month ago

still needs a padding fix for the section

Screenshot 2024-07-23 at 15 50 09
mind-adobe commented 1 month ago

@asthabh23

still needs a padding fix for the section

Should I also style the sections when creating the blocks? Also on their site, there are some "confetti" svgs for this block. Should I add them or are they unnecessary?

asthabh23 commented 1 month ago

@mind-adobe yes, we need to add them! I was about to mention that

asthabh23 commented 1 month ago

For section padding - I will create a separate issue then so it can be taken care of in one shot here is the new issue: https://github.com/aemsites/piramal/issues/29

asthabh23 commented 1 month ago

@mind-adobe , please see and address the issues under accessibility: https://pagespeed.web.dev/analysis/https-10-homepage-testimonials-block--piramal--aemsites-hlx-page/926ft22tc1?utm_source=psi&utm_medium=redirect&form_factor=mobile

this gets highlighted in SEO as well

mind-adobe commented 1 month ago

@mind-adobe , please see and address the issues under accessibility: https://pagespeed.web.dev/analysis/https-10-homepage-testimonials-block--piramal--aemsites-hlx-page/926ft22tc1?utm_source=psi&utm_medium=redirect&form_factor=mobile

this gets highlighted in SEO as well

Fixed it, should be good now