aemsites / piramal

Apache License 2.0
0 stars 0 forks source link

8 homepage columns block #37

Closed mind-adobe closed 3 months ago

mind-adobe commented 3 months ago

Added 2 variations for the column block: badges + content-center/content-left

Fix #8

Test URLs:

aem-code-sync[bot] commented 3 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [7500db8](https://github.com/aemsites/piramal/commit/7500db851ed45f1f8e828f97fa0abf9d5c57db4d) :white_check_mark: (latest) * [6b33095](https://github.com/aemsites/piramal/commit/6b33095c3d193dd0c4af8861b919c57694721255) :white_check_mark: * [c22c8f0](https://github.com/aemsites/piramal/commit/c22c8f027c1b0c5eb542d169a9f6c724879ce97f) :white_check_mark: * [9221d13](https://github.com/aemsites/piramal/commit/9221d13882501dfa41aeccf22b230bc44327945e) :white_check_mark: * [95cc8f9](https://github.com/aemsites/piramal/commit/95cc8f9e0ceb2d54e0609b8bfaf20e3a6d11d78b) :white_check_mark: * [d6cfe99](https://github.com/aemsites/piramal/commit/d6cfe99bbb58438027badfbfef94997ed6bb8afd) :white_check_mark: * [9dd511e](https://github.com/aemsites/piramal/commit/9dd511e58b00df990c06b24a08863dd4995b51ba) :white_check_mark: * [711fab9](https://github.com/aemsites/piramal/commit/711fab9ea86c3ef5cbc8f2320d5e5497b2a5b8ab) :white_check_mark: * [1576672](https://github.com/aemsites/piramal/commit/1576672d7c20cc64db17e1d548922528a99057c9) :white_check_mark: * [abb64a5](https://github.com/aemsites/piramal/commit/abb64a5658ff47097924b011b1466b5f1e19317e) :white_check_mark: * [166fad5](https://github.com/aemsites/piramal/commit/166fad5dc1e85c5b1e8af7739168013a14c1c4fd) :white_check_mark: * [d21437c](https://github.com/aemsites/piramal/commit/d21437c27059aaa62105d3accd7b3dd7ea617072) :white_check_mark: * [57a3ab8](https://github.com/aemsites/piramal/commit/57a3ab822e5c200716303743d11dec5eb17af855) :white_check_mark: * [b913ff0](https://github.com/aemsites/piramal/commit/b913ff05639f3e8e95908a1b97a4f23fe95ac82d) :white_check_mark: * [dd04a98](https://github.com/aemsites/piramal/commit/dd04a98ac5526f5d992799d7a44727c15851654f) :white_check_mark:
aem-code-sync[bot] commented 3 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
asthabh23 commented 3 months ago

@mind-adobe , i do see fonts styling not matching upto the original site. maybe you need to see the font-weight and the font type used. (our version seems to have headings also different, can you please check again?)

Screenshot 2024-07-25 at 18 43 20
asthabh23 commented 3 months ago

additionally, as we merge this PR into main, it would be great if we can have a final check on headings and section paddings and spacing. (since hero carousel is also now into main, so we can have a better look at the alignments - I will create a separate issue for this)

mind-adobe commented 3 months ago

@mind-adobe , i do see fonts styling not matching upto the original site. maybe you need to see the font-weight and the font type used. (our version seems to have headings also different, can you please check again?)

About this I wanted to ask you. Should this be done through authoring (for example using a heading instead of a

tag) or should we just overwrite it in the code? I am not asking specifically for this issue, but in general

asthabh23 commented 3 months ago

@mind-adobe , great point - we discussed and I have converted the titles in the columns block to h3 you can now use this directly to style.

mind-adobe commented 3 months ago

@asthabh23 it should be fine now

asthabh23 commented 3 months ago

@mind-adobe , can you please add some gap between the column cells. this will wrap the text also to look like what we have on original site

Screenshot 2024-07-26 at 13 52 16

The same applies for other columns layouts as well

mind-adobe commented 3 months ago

@mind-adobe , can you please add some gap between the column cells. this will wrap the text also to look like what we have on original site

Done. Added bigger gaps between columns.