Closed mind-adobe closed 3 months ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/ |
@mind-adobe , i do see fonts styling not matching upto the original site. maybe you need to see the font-weight and the font type used. (our version seems to have headings also different, can you please check again?)
additionally, as we merge this PR into main, it would be great if we can have a final check on headings and section paddings and spacing. (since hero carousel is also now into main, so we can have a better look at the alignments - I will create a separate issue for this)
@mind-adobe , i do see fonts styling not matching upto the original site. maybe you need to see the font-weight and the font type used. (our version seems to have headings also different, can you please check again?)
About this I wanted to ask you. Should this be done through authoring (for example using a heading instead of a
tag) or should we just overwrite it in the code? I am not asking specifically for this issue, but in general
@mind-adobe , great point - we discussed and I have converted the titles in the columns block to h3
you can now use this directly to style.
@asthabh23 it should be fine now
@mind-adobe , can you please add some gap between the column cells. this will wrap the text also to look like what we have on original site
The same applies for other columns layouts as well
@mind-adobe , can you please add some gap between the column cells. this will wrap the text also to look like what we have on original site
Done. Added bigger gaps between columns.
Added 2 variations for the column block: badges + content-center/content-left
Fix #8
Test URLs: