search

aemsites / piramal

Apache License 2.0
0 stars 0 forks source link

Issue 2 #90

Closed Sk-Zahid closed 3 months ago

Sk-Zahid commented 3 months ago

Fix #2

Test URLs:

aem-code-sync[bot] commented 3 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [7e75a7e](https://github.com/aemsites/piramal/commit/7e75a7ea8e86f8eee52997032ff2b39d57be751f) :white_check_mark: (latest) * [abb7959](https://github.com/aemsites/piramal/commit/abb79590516120b63fbb7868b29201f4e4ffb266) :white_check_mark: * [b7a0da5](https://github.com/aemsites/piramal/commit/b7a0da5711dcdea323d3b3acfdbde2ea58a3db77) :white_check_mark: * [5a8f9b4](https://github.com/aemsites/piramal/commit/5a8f9b4852d1eb15fd9f176811b16ffd18d7ab3c) :white_check_mark: * [20a9e08](https://github.com/aemsites/piramal/commit/20a9e0832ed63ae1d26e00f0e2f498f24aff24f8) :white_check_mark: * [0e250e7](https://github.com/aemsites/piramal/commit/0e250e717cf67639bb895ce4653ed21e428ea1e8) :white_check_mark: * [8652e0e](https://github.com/aemsites/piramal/commit/8652e0e6413140826b2c1b3c2eeb65d1085782f4) :white_check_mark: * [2ecf056](https://github.com/aemsites/piramal/commit/2ecf05670cf434a76ab318a7759128f07533f775) :white_check_mark: * [5d6ee2d](https://github.com/aemsites/piramal/commit/5d6ee2d1f2079007ae8a0a3f3be4a5d0c7d54ad2) :white_check_mark: * [6c2795f](https://github.com/aemsites/piramal/commit/6c2795f7e1d714d478112c291f99b12518be9e7c) :white_check_mark: * [a156642](https://github.com/aemsites/piramal/commit/a15664238b032dc4bd1973eea1ce887a31f6c6b0) :white_check_mark: * [408cc62](https://github.com/aemsites/piramal/commit/408cc621aa51a11be4af46c30729adb285215f49) :white_check_mark:
aem-code-sync[bot] commented 3 months ago
Page Scores Audits Google
/ PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
asthabh23 commented 3 months ago

@Sk-Zahid , is this still in progress?

few observations so far:

  1. The width of the dropdown is not full screen as on original site

    Screenshot 2024-08-02 at 11 21 22

  2. mobile view is broken

    Screenshot 2024-08-02 at 11 22 12
Sk-Zahid commented 3 months ago

@Sk-Zahid , is this still in progress?

few observations so far:

  1. The width of the dropdown is not full screen as on original site
Screenshot 2024-08-02 at 11 21 22
  1. mobile view is broken
Screenshot 2024-08-02 at 11 22 12

Please reload the page for mobile device

Sk-Zahid commented 3 months ago
  1. The selected item and its subitems also need to have a different background color (as on original site). Please see closely, the entire mobile menu isn't white (varies based on item selections)

This seems to resolve if other any changes please lets know

Sk-Zahid commented 3 months ago

Hi @asthabh23 @mind-adobe @buuhuu , Please review the code and update us.