aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

2 footer #23

Closed allanhero closed 5 months ago

allanhero commented 5 months ago

Fix #2

Test URLs:

Comments: To test the short version of the footer, I created a footer file called footer-short, which can be included as the official footer on the page for display. As for the CTA with the title Get Informed appears only in one of the variants, it should be added separately as a separate form.

Variants of the footer: Variant 1 - https://www.shredit.com/en-us Variant 2 - https://www.shredit.com/en-us/marketing/shred-it-document-destruction

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [ad8eda4](https://github.com/aemsites/stericycle-shared/commit/ad8eda40d4b454c49440565f99b6a41e0f2f190c) :white_check_mark: (latest) * [c9cca43](https://github.com/aemsites/stericycle-shared/commit/c9cca438182d069c06f28d9e05a8d1636c0af0d3) :white_check_mark: * [948424b](https://github.com/aemsites/stericycle-shared/commit/948424b95986bccf391235bf9f102e34e4643e54) :white_check_mark: * [56ee072](https://github.com/aemsites/stericycle-shared/commit/56ee07294840830141c0a4736319c3d834ab242c) :white_check_mark: * [9159675](https://github.com/aemsites/stericycle-shared/commit/91596752fbccf1ea557eb84c151eae89abdfcb0a) :white_check_mark: * [7af3155](https://github.com/aemsites/stericycle-shared/commit/7af315528a4151b513fa1ac97a67a89575cd601b) :white_check_mark: * [b2a8722](https://github.com/aemsites/stericycle-shared/commit/b2a87229b7f6c4205d2f41c1f8d11e72e3407609) :white_check_mark: * [f34d436](https://github.com/aemsites/stericycle-shared/commit/f34d4363c2873d2335e215d0c52dccaff8b06413) :white_check_mark: * [0eb0021](https://github.com/aemsites/stericycle-shared/commit/0eb002109cc2d044cba0d95d4cbe0f3d6b037079) :white_check_mark: * [86c77ca](https://github.com/aemsites/stericycle-shared/commit/86c77ca68bbb8f5c160259c126e6722197efc153) :white_check_mark: * [4671cf3](https://github.com/aemsites/stericycle-shared/commit/4671cf3cf68abf241ea797b98fd4a22d302d02b6) :white_check_mark: * [29be9e3](https://github.com/aemsites/stericycle-shared/commit/29be9e3e6847ab5d8d5d92927c3a400e2df4d55f) :white_check_mark:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/en-us PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
dkuntze commented 5 months ago

@allanhero can you fix the minor linting flags? Otherwise, it looks pretty good.

allanhero commented 5 months ago

Overall looks quite good to me. Added a few comments

Thank you for your feedback. I have made the corrections. If you have any more recommendations, I would be happy to consider them.

allanhero commented 5 months ago

@allanhero can you fix the minor linting flags? Otherwise, it looks pretty good.

The lint errors have been resolved, I look forward to any other recommendations.

seanathero commented 5 months ago

@allanhero looks great. My only concern is around using pt and pc units which I'm seeing in some of the css. I realize you're matching current site, but I think my preference would be to use px instead. Thoughts @dkuntze @kronnox on this?

dkuntze commented 5 months ago

Px or rem would be the preference

allanhero commented 5 months ago

Px or rem would be the preference

I'm working on this change!

allanhero commented 5 months ago

Px or rem would be the preference

Issue fixed!