Closed allanhero closed 5 months ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | |
---|---|---|---|
/en-us |
@allanhero can you fix the minor linting flags? Otherwise, it looks pretty good.
Overall looks quite good to me. Added a few comments
Thank you for your feedback. I have made the corrections. If you have any more recommendations, I would be happy to consider them.
@allanhero can you fix the minor linting flags? Otherwise, it looks pretty good.
The lint errors have been resolved, I look forward to any other recommendations.
@allanhero looks great. My only concern is around using pt and pc units which I'm seeing in some of the css. I realize you're matching current site, but I think my preference would be to use px instead. Thoughts @dkuntze @kronnox on this?
Px or rem would be the preference
Px or rem would be the preference
I'm working on this change!
Px or rem would be the preference
Issue fixed!
Fix #2
Test URLs:
Comments: To test the short version of the footer, I created a footer file called footer-short, which can be included as the official footer on the page for display. As for the CTA with the title Get Informed appears only in one of the variants, it should be added separately as a separate form.
Variants of the footer: Variant 1 - https://www.shredit.com/en-us Variant 2 - https://www.shredit.com/en-us/marketing/shred-it-document-destruction