search

aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

Add clickable cards block #25

Closed kronnox closed 5 months ago

kronnox commented 5 months ago

Resolve #21

Test URLs:

aem-code-sync[bot] commented 5 months ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [9ee75f8](https://github.com/aemsites/stericycle-shared/commit/9ee75f83f290b62a72963f06bf05d5e4c6a4d34d) :white_check_mark: (latest) * [459cf5d](https://github.com/aemsites/stericycle-shared/commit/459cf5d02c387e230cf7c423a9b776aa7764b487) :white_check_mark: * [fac1b18](https://github.com/aemsites/stericycle-shared/commit/fac1b184950092eb89e12f30df2b1eea109cef97) :white_check_mark: * [109058b](https://github.com/aemsites/stericycle-shared/commit/109058b03554fa330be9b70a94cb61ecf0a334f4) :white_check_mark: * [4f13ea7](https://github.com/aemsites/stericycle-shared/commit/4f13ea7d95627ae150bc40836d1e0e50e79ec05d) :white_check_mark: * [58625f3](https://github.com/aemsites/stericycle-shared/commit/58625f3b6e97ce0673df2527fe1f98d98f9641b3) :white_check_mark:
aem-code-sync[bot] commented 5 months ago
Page Scores Audits Google
/en-us PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
seanathero commented 5 months ago

@dkuntze @kronnox Note the current site provides an aria-label attr on the links to provide more context to screen readers. I think we lose that here.

dkuntze commented 5 months ago

@dkuntze @kronnox Note the current site provides an aria-label attr on the links to provide more context to screen readers. I think we lose that here.

We can fix that

kronnox commented 5 months ago

Note the current site provides an aria-label attr on the links to provide more context to screen readers. I think we lose that here.

@seanathero Taking care of that in a separate PR (if code changes are even necessary) to not further block merging here.