aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

feat: support for configuring form in marketing template #376

Closed ravise5 closed 1 month ago

ravise5 commented 1 month ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #

Test URLs:

aem-code-sync[bot] commented 1 month ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [b00ab45](https://github.com/aemsites/stericycle-shared/commit/b00ab4588c054d3cd3c108cc766a44fd745f3b48) :white_check_mark: (latest) * [c961db0](https://github.com/aemsites/stericycle-shared/commit/c961db0843d81373e4ff378d9c096066a09bb5c1) :white_check_mark: * [31e33c6](https://github.com/aemsites/stericycle-shared/commit/31e33c6007a7ee41d7aab732d62b9ce65d436a16) :white_check_mark: * [2862237](https://github.com/aemsites/stericycle-shared/commit/286223778d2f7489040669a25a353a04b7b866b1) :white_check_mark:
aem-code-sync[bot] commented 1 month ago
Page Scores Audits Google
:iphone: /en-us/marketing/locations/paper-shredding-columbus PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/marketing/locations/paper-shredding-columbus PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
ravise5 commented 1 month ago

@jalagari in doc metadata we are adding form like

form-path /forms/legacy-sem-page
jalagari commented 1 month ago

@jalagari in doc metadata we are adding form like

form-path /forms/legacy-sem-page

Any reason for not adding direct link?

ravise5 commented 1 month ago

@jalagari in doc metadata we are adding form like form-path /forms/legacy-sem-page

Any reason for not adding direct link?

No I see they have added footer also as relative path so just aligned to that. Also to avoid confusion why is form a json for doc author.