aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

Issue hero image rendering #391

Closed jindaliiita closed 4 weeks ago

jindaliiita commented 4 weeks ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #332

Test URLs:

aem-code-sync[bot] commented 4 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [6c90279](https://github.com/aemsites/stericycle-shared/commit/6c902795721dea08ef5144565c78e4cfaef774c9) :white_check_mark: (latest) * [7539a5a](https://github.com/aemsites/stericycle-shared/commit/7539a5abe3d84bd3a62576e9fe13d095122c063d) :white_check_mark: * [dbd6e01](https://github.com/aemsites/stericycle-shared/commit/dbd6e01d3077b8744ec659826b6323ffd0bfc282) :white_check_mark:
aem-code-sync[bot] commented 4 weeks ago
Page Scores Audits Google
:iphone: /en-us/secure-shredding-services PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/secure-shredding-services PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
jindaliiita commented 4 weeks ago

Added custom breakpoints width for the hero block and also loading image eagerly

jindaliiita commented 4 weeks ago

@colinvlasak Can you please check if image quality improved with this change ? Sample URL -> https://issue-hero--shredit--stericycle.aem.page/en-us/secure-shredding-services

jindaliiita commented 4 weeks ago

Also covers https://github.com/aemsites/stericycle-shared/issues/211

colinvlasak commented 4 weeks ago

@jindaliiita looks better. Can we apply this to all Hero images across the site?

jindaliiita commented 4 weeks ago

@jindaliiita looks better. Can we apply this to all Hero images across the site?

It will be automatically applied

colinvlasak commented 4 weeks ago

@jindaliiita great, let me know once rolled out and I will QA a number of pages to check the improvement across the site