search

aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

Columns Block - Issues #442

Open colinvlasak opened 2 weeks ago

colinvlasak commented 2 weeks ago

Columns With Video - https://main--shredit--stericycle.aem.page/tools/sidekick/library.html?plugin=blocks&path=/tools/sidekick/blocks/columns&index=7

  1. Block not respecting line breaks in text section. Please ensure text formatting works across all options. Proper line spacing, bullets, etc.
  2. Tablet and mobile video rendering compresses video vertically. The video embed aspect ratio should not change to mobile/tablet. image

Columns With Icons

  1. Mobile Learn More Rendering as secondaey CTA vs. text link with arrow. Should render as the latter.
  2. Arrow rendering doesn't match live site. Can we update this (minor) image image
kronnox commented 2 weeks ago

Looking at the implementation... @colinvlasak Did you notice the missing line-breaks elsewhere on the site? On a first look this seems like a sitewide style, but I don't want to touch it without confirmation, to not break other sections and blocks.

colinvlasak commented 2 weeks ago

@kronnox did a quick check and not really seeing the issue on other components/blocks/pages at the moment. Seems mostly with this block. We did have spacing issues across the site previously on blog and a few other pages but they appear to be resolved.

@MarquiseRosier may have more background

colinvlasak commented 2 days ago

@MarquiseRosier it looks like issues 1 and 2 in this ticket are fixed. But 3 and 4 are still outstanding.