aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

feat:support to configure multiple modal triggers #463

Closed ravise5 closed 5 days ago

ravise5 commented 2 weeks ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #362

Test URLs:

aem-code-sync[bot] commented 2 weeks ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [4f5c07a](https://github.com/aemsites/stericycle-shared/commit/4f5c07a887191b77fa44834e8295eb604cad6157) :white_check_mark: (latest) * [b5a228d](https://github.com/aemsites/stericycle-shared/commit/b5a228d1845de559b0b9181e0c17b48518ee425a) :white_check_mark: * [47fd637](https://github.com/aemsites/stericycle-shared/commit/47fd63702f23f39dcee06b5875da643b5aa49a24) :white_check_mark: * [0866164](https://github.com/aemsites/stericycle-shared/commit/0866164ccc14de1495b9a3ce4506eebec609a56a) :white_check_mark: * [d57e2e4](https://github.com/aemsites/stericycle-shared/commit/d57e2e4ab21126b9e74e10efea3035d63b56dca4) :white_check_mark: * [a6d8988](https://github.com/aemsites/stericycle-shared/commit/a6d89885a4b99537305bc8650c2ba9d7e84d0331) :white_check_mark: * [4e3bf6d](https://github.com/aemsites/stericycle-shared/commit/4e3bf6db5b37af63f5073528f1e5467616984022) :white_check_mark: * [78b795f](https://github.com/aemsites/stericycle-shared/commit/78b795f4285a41696cad294e5b08f7742622bd9b) :white_check_mark: * [0bf8d41](https://github.com/aemsites/stericycle-shared/commit/0bf8d417736ca5a1ceb89f195c3675e6e9fde8f0) :white_check_mark: * [d3aded9](https://github.com/aemsites/stericycle-shared/commit/d3aded97b243f45a1b7b27c8b228d681f26d45ef) :white_check_mark: * [8dd09cb](https://github.com/aemsites/stericycle-shared/commit/8dd09cbf7fc964430d10fce71dba78a316ec9da5) :white_check_mark: * [2dd164b](https://github.com/aemsites/stericycle-shared/commit/2dd164b9c943e4e47bdf8cb4074a8f52eda3f261) :white_check_mark: * [f4cb04e](https://github.com/aemsites/stericycle-shared/commit/f4cb04e93ecaf8f53ad436f0bc4d56a7f5ff5ed9) :white_check_mark: * [b46cd9b](https://github.com/aemsites/stericycle-shared/commit/b46cd9b75f170c2fb0bbb1be606ee1d3b6e24271) :white_check_mark: * [50e6c7f](https://github.com/aemsites/stericycle-shared/commit/50e6c7ff355253bbd234681d4a5afc8f74845ce0) :white_check_mark:
aem-code-sync[bot] commented 2 weeks ago
Page Scores Audits Google
:iphone: /drafts/ravi/one-off-shredding-service PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /drafts/ravi/one-off-shredding-service PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:iphone: /en-us/email/offer PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/email/offer PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:iphone: /en-us/marketing/locations/paper-shredding-columbus PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/marketing/locations/paper-shredding-columbus PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
ravise5 commented 1 week ago

Page speed for failing URL: https://pagespeed.web.dev/analysis/https-trigger--shredit--stericycle-aem-page-drafts-ravi-scroll/zkzdgq0jdv?utm_source=psi&utm_medium=redirect&form_factor=desktop