search

aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

issue-446 changes wrt to facet list #480

Closed jindaliiita closed 1 week ago

jindaliiita commented 1 week ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #446

Test URLs:

aem-code-sync[bot] commented 1 week ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [6d77e29](https://github.com/aemsites/stericycle-shared/commit/6d77e29d2e6e27d56281a53cfe722ac91681e64b) :white_check_mark: (latest) * [057f1f0](https://github.com/aemsites/stericycle-shared/commit/057f1f0348276fd4e2af7a6f5e32b01d94563ab7) :white_check_mark: * [dc17b7f](https://github.com/aemsites/stericycle-shared/commit/dc17b7f0c94059f07531761064ca7e90c5f552c9) :white_check_mark: * [b73614d](https://github.com/aemsites/stericycle-shared/commit/b73614d42655008bab76156f37a642764f201c12) :white_check_mark: * [7df8daf](https://github.com/aemsites/stericycle-shared/commit/7df8dafb4e72cb0fe41875d7657b86b20deaead6) :white_check_mark: * [6422d23](https://github.com/aemsites/stericycle-shared/commit/6422d2370b0933cd7f440187732c24a09e672cda) :white_check_mark: * [956c34a](https://github.com/aemsites/stericycle-shared/commit/956c34a86a4d2a5e48e300a97854d66039d8c622) :white_check_mark:
aem-code-sync[bot] commented 1 week ago
Page Scores Audits Google
:iphone: /en-us/resource-center PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/resource-center PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
bstopp commented 1 week ago

I don't think that TBT is a fluke, There's something on this page that's tanking the performance.

jindaliiita commented 1 week ago

I don't think that TBT is a fluke, There's something on this page that's tanking the performance.

Yes checking that

jindaliiita commented 1 week ago

I am out of options for the TBT issue on this page. @MarquiseRosier @bstopp @kronnox Do you any insights here ?

kronnox commented 1 week ago

I think it's unrelated to this PR. If you don't find anything obvious, feel free to open up a separate issue for it

jindaliiita commented 1 week ago

@bstopp I am creating a follow-up issue for the TBT aspect, as I am unable to determine the exact cause of the TBT issue, and it is not related to the changes in the PR. Could you please review this PR once again ?

jindaliiita commented 1 week ago

@bstopp Can you please check this