search

aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

STERI-016-57: Update buttons styling #482

Closed conaryh closed 1 week ago

conaryh commented 1 week ago

Ticket https://herodigital.atlassian.net/browse/STERI016-57

Fix #STERI016-50

Changes:

Demo URL: https://feat-steri016-57--shredit--stericycle.aem.page/drafts/conary/document

Test URLs:

aem-code-sync[bot] commented 1 week ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [c132c97](https://github.com/aemsites/stericycle-shared/commit/c132c979620bec2fb591cc48ae28935bbe9d4a2e) :white_check_mark: (latest) * [af62341](https://github.com/aemsites/stericycle-shared/commit/af62341e09bd88441baedd863b66d8cd72351ddf) :white_check_mark: * [5c75eb4](https://github.com/aemsites/stericycle-shared/commit/5c75eb4238baf55a730de90f8dc45d2bf2e348a7) :white_check_mark: * [bf0b9fd](https://github.com/aemsites/stericycle-shared/commit/bf0b9fd7d49228ed329f51fc87803a6293887979) :white_check_mark: * [7009f27](https://github.com/aemsites/stericycle-shared/commit/7009f27e34d9e26960e79d691c793026632f53e1) :white_check_mark: * [3532ebe](https://github.com/aemsites/stericycle-shared/commit/3532ebe3ae365313a7fb1e27eecf35b948db9dc0) :white_check_mark: * [2f74005](https://github.com/aemsites/stericycle-shared/commit/2f740052473e36c069b5ae811cfe513c2ca9454d) :white_check_mark:
aem-code-sync[bot] commented 1 week ago
Page Scores Audits Google
:iphone: / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: / PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:iphone: /drafts/conary/document PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /drafts/conary/document PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
seanathero commented 1 week ago

@conaryh thanks. One thing I'm noticing is the cta at the bottom of the home page seems to have an issue Screenshot 2024-11-13 at 12 50 42 PM Screenshot 2024-11-13 at 12 50 30 PM

conaryh commented 1 week ago

@seanathero PR updated.

seanathero commented 1 week ago

Scanning the home page, two issues we need to look at to understand how are changes are affecting current elements Screenshot 2024-11-14 at 7 45 28 AM Screenshot 2024-11-14 at 7 45 33 AM

Using https://main--shredit--stericycle.aem.live/en-us for comparison