Closed jindaliiita closed 1 week ago
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.
Page | Scores | Audits | ||
---|---|---|---|---|
:iphone: | /en-us/secure-shredding-services/one-off-shredding-service | |||
:desktop_computer: | /en-us/secure-shredding-services/one-off-shredding-service |
This needs a separate smaller icon size for tablet / mobile. Also you should probably use
var(--icon-size-xl)
instead of the hardcoded4rem
. Otherwise LGTM
For small devices, they seem to be too small, which is why I maintained similar behavior for all screens.
For small devices, they seem to be too small, which is why I maintained similar behavior for all screens.
You are right. I adjusted my PR to match this behaviour.
The icon sizing for the column blocks seems to be very inconsistently done in general. Sometime it's set on the wrapper, sometimes on the image. This is bad. I think we wouldn't even need so many variants of the column block if we would just be using the xl-icons
style on the blocks / sections instead. But I don't really want to touch this, since it feels like it could break a lot of stuff.
@kronnox - is your review change required still valid? if not can you dismiss it?
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #466
Test URLs: