search

aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

Desktop Margin Issues #504

Closed colinvlasak closed 4 days ago

colinvlasak commented 1 week ago

Some sections on our service section of the site are not following the page margins. They are rendering full width vs boxed in the proper margins. This is new issue that just popped up today. I am wondering if this has to do with the page fixes on the SEM pages as they have different widths.

Example: https://main--shredit--stericycle.aem.page/en-us/secure-shredding-services/one-off-shredding-service

image

image

MarquiseRosier commented 1 week ago

@colinvlasak yup that's on me; apologies, I made a sweeping margin change; that should be very easy to correct.

MarquiseRosier commented 1 week ago

@colinvlasak I think we should have a conversation about standardizing margins? I'm noticing that these are the only pages with this kind of different margin? Even within the marketing pages other pages don't really have this full screen styling?

colinvlasak commented 6 days ago

@MarquiseRosier the new marketing pages have different margins then the rest of the site. They are closer to full width. We would like to keep these as is as the pages were designed with the wider margins in mind. This should only represent about a handful of pages. They are the pages that have the Shred-it By The Numbers with the form beside them at the bottom of the page.

The rest of the site should have the same margins across all pages on desktop and mobile.

MarquiseRosier commented 6 days ago

okay! Thanks @colinvlasak for the context : I'll be pushing the fix soon!)