aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

issue-489 Service location map changes #520

Open jindaliiita opened 2 days ago

jindaliiita commented 2 days ago

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #489

Test URLs:

aem-code-sync[bot] commented 2 days ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [faebe35](https://github.com/aemsites/stericycle-shared/commit/faebe35efdaa4d8072c3ffe060d5abc21e891406) :white_check_mark: (latest)
aem-code-sync[bot] commented 2 days ago
Page Scores Audits Google
:iphone: /en-us/service-locations PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/service-locations PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
kronnox commented 2 days ago

Functionality wise this should work. But I don't like the disabled style with the blur, that's just confusing me. Should rather be grayed out and / or a loading spinner.