search

aemsites / stericycle-shared

Edge Delivery Service Site for Stericycle sites
https://www.shredit.com, https://www.stericycle.com
Apache License 2.0
0 stars 1 forks source link

Lazy load video observer. #524

Closed bstopp closed 2 days ago

bstopp commented 2 days ago

Fix #523

Test URLs:

aem-code-sync[bot] commented 2 days ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

Commits * [57e4068](https://github.com/aemsites/stericycle-shared/commit/57e4068af73f4b9ce26278478fc8fb822c39c050) :white_check_mark: (latest) * [cf09235](https://github.com/aemsites/stericycle-shared/commit/cf092355ddb88b1e8ee3400179c873f357d26224) :white_check_mark:
aem-code-sync[bot] commented 2 days ago
Page Scores Audits Google
:iphone: /en-us/resource-center/videos/data-breaches-understanding-todays-threats PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/resource-center/videos/data-breaches-understanding-todays-threats PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
aem-code-sync[bot] commented 2 days ago
Page Scores Audits Google
:iphone: /en-us/resource-center/videos/data-breaches-understanding-todays-threats PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
:desktop_computer: /en-us/resource-center/videos/data-breaches-understanding-todays-threats PERFORMANCE A11Y SEO BEST PRACTICES SI FCP LCP TBT CLS PSI
jindaliiita commented 2 days ago

Why can't we display an image first and then show the actual video when the play button is clicked ? https://sidekick-library--aem-block-collection--adobe.aem.page/tools/sidekick/library.html?plugin=blocks&path=/block-collection/video&index=3 For above the fold content at least we can do this to enhance LHS

bstopp commented 2 days ago

Why can't we display an image first and then show the actual video when the play button is clicked ? https://sidekick-library--aem-block-collection--adobe.aem.page/tools/sidekick/library.html?plugin=blocks&path=/block-collection/video&index=3 For above the fold content at least we can do this to enhance LHS

We can, but someone has to author that image. The were no placeholder images in any of the Video pages.

And we need to handle the context of no placeholder. If there's a placeholder image there's no LHS issue. If there isn't there was a huge issue.

bstopp commented 2 days ago

That should work for tricking LHS. Just wondering if we can do this somehow without degrading the actual user-experience and them having to wait for 4s. before the content appears

Force a placeholder - then the library isn't loaded til they click the play button. But without a placeholder 🤷