bstopp commented 16 hours ago

This PR is intended to fix some issues with authoring both Columns and Tabs blocks.

In an effort to expedite as solution I have split these two blocks into separate logic paths.

Added "Wrap Mobile" Columns Type

This will use the number of authored columns as the maximum allowed at desktop viewport. At smaller views it will use wrapping logic for fewer entries per row. This prevents items from shrinking too small, while allowing for an improved authoring experience.

Only way to get to this logic path is to use the wrap mobile keyword variation.

Added "Fetch" Tabs Type

In this variation of the block, rather than authoring each tab in a row - you simply specify the URL of the content. The target page will be fetched. Each section in the target page becomes a Tab. The title of the tab is controlled by the Section Metadata "Title" attribute.

Again, the only way to use this type of block is to use the fetch keyword variation.

Using this approach I should have prevented any impact to existing Column or Tab implementations across the site, while supporting a new feature set.

Fix #441

Test URLs:

After:
- https://feat-fetched-tabs--shredit--stericycle.aem.page/en-us/fragments/who-we-serve-tabs (Column Updates)
- https://feat-fetched-tabs--shredit--stericycle.aem.page/en-us/who-we-serve (Tab Updates)

aem-code-sync[bot] commented 16 hours ago

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

[ ] Re-run PSI checks
[ ] Re-sync branch

Commits

* [ff65ff5](https://github.com/aemsites/stericycle-shared/commit/ff65ff59697dfbc15c4d79ed94706f219976dd33) :white_check_mark: (latest) * [ce64b3d](https://github.com/aemsites/stericycle-shared/commit/ce64b3d5785e0c352a25d13f297b6398e612eea3) :white_check_mark: * [39cbd39](https://github.com/aemsites/stericycle-shared/commit/39cbd394b7f81f433239e259ec450cc715ab4cd8) :white_check_mark: * [9a33617](https://github.com/aemsites/stericycle-shared/commit/9a33617ec09df02871f19180fe3c87dfb6606a82) :white_check_mark: * [884d9cd](https://github.com/aemsites/stericycle-shared/commit/884d9cd6998702c2abf4ad61038ef1a4b9c7caf6) :white_check_mark: * [4a9c97b](https://github.com/aemsites/stericycle-shared/commit/4a9c97b5fb61d942baf0261df7efab128f38434f) :white_check_mark: * [1137b5a](https://github.com/aemsites/stericycle-shared/commit/1137b5a01705b117db52f0c7df24a59a90a97efb) :white_check_mark:

aem-code-sync[bot] commented 16 hours ago

	Page	Scores	Audits	Google
:iphone:	/en-us/fragments/who-we-serve-tabs
:desktop_computer:	/en-us/fragments/who-we-serve-tabs
:iphone:	/en-us/who-we-serve
:desktop_computer:	/en-us/who-we-serve