blog search

[dkuntze]

Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):

Fix #27

Test URLs:

• Before: https://main--shredit--stericycle.aem.page/en-us/blog
• https://www.shredit.com/en-us/blog
• After:
  • https://27-blog-search--shredit--stericycle.aem.live/en-us/blog
  • https://27-blog-search--stericycle-shared--aemsites.aem.live/en-us/blog

[aem-code-sync[bot]]

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed. In case there are problems, just click a checkbox below to rerun the respective action.

• [ ] Re-run PSI checks
• [ ] Re-sync branch

Commits

* [23cc1c4](https://github.com/aemsites/stericycle-shared/commit/23cc1c41ed81d22bd56c1904cba94448d5779522) :white_check_mark: (latest) * [226ac54](https://github.com/aemsites/stericycle-shared/commit/226ac548a11b61408de8796326bf5b5b59bcc202) :white_check_mark: * [ccd45c4](https://github.com/aemsites/stericycle-shared/commit/ccd45c46d84489806f8aa269f1b361976a9d6a3c) :white_check_mark: * [0642124](https://github.com/aemsites/stericycle-shared/commit/0642124e001f1b33c33e8aacf457a05b63a2ae8b) :white_check_mark: * [d4dfeb5](https://github.com/aemsites/stericycle-shared/commit/d4dfeb5cccddf5039e1a8a878c3d075ee604d8fb) :white_check_mark: * [fb99723](https://github.com/aemsites/stericycle-shared/commit/fb997235a1732cac7bfa4d3283af2053a11da2cf) :white_check_mark: * [75ed34b](https://github.com/aemsites/stericycle-shared/commit/75ed34b80b54dcb81b29052ad7998e3820c76245) :white_check_mark: * [21e3cdc](https://github.com/aemsites/stericycle-shared/commit/21e3cdc4ae36d12cb20e363eba66cc8bdc691844) :white_check_mark: * [0c8022b](https://github.com/aemsites/stericycle-shared/commit/0c8022bbc7df6728e07796ecf59d8eda18dfccb7) :white_check_mark: * [76ca21a](https://github.com/aemsites/stericycle-shared/commit/76ca21ae21092d3721f7d39ebab7f0c4ebad4d64) :white_check_mark: * [246fe65](https://github.com/aemsites/stericycle-shared/commit/246fe658e4bda4e4154cd59f14249bbc37cd38de) :white_check_mark: * [284c9b2](https://github.com/aemsites/stericycle-shared/commit/284c9b24c50e3f231d141f46f26266a3076b1c3f) :white_check_mark: * [02e29bc](https://github.com/aemsites/stericycle-shared/commit/02e29bce1a31734be3c4ed41db6f2fb944950918) :white_check_mark: * [5c1397d](https://github.com/aemsites/stericycle-shared/commit/5c1397d6068097ef39115cca4f818303fbb313a5) :white_check_mark: * [777a0e7](https://github.com/aemsites/stericycle-shared/commit/777a0e7bd1b199c7717e1ddfe5008afd598692a3) :white_check_mark: * [69b7060](https://github.com/aemsites/stericycle-shared/commit/69b70606e095a50e1ed7715a445d26fcec7d1efa) :white_check_mark: * [f65b336](https://github.com/aemsites/stericycle-shared/commit/f65b336ae010000c4ba3d8c206aa7592b91ed662) :white_check_mark: * [50bdb10](https://github.com/aemsites/stericycle-shared/commit/50bdb10b28c5d9d1bbe44b059c49cf1077b955a2) :white_check_mark: * [c465726](https://github.com/aemsites/stericycle-shared/commit/c465726fbbb736179d0ce4bd22291a0e65830a83) :white_check_mark: * [cb54d38](https://github.com/aemsites/stericycle-shared/commit/cb54d38a43f0ec69d48d7bf731128ff82278ce42) :white_check_mark: * [5b67c00](https://github.com/aemsites/stericycle-shared/commit/5b67c006a6558e2cd6ae8a425add4f60d9f44379) :white_check_mark: * [e5fba9f](https://github.com/aemsites/stericycle-shared/commit/e5fba9fde66bd14eae08e1dab7697aeb4fa065b5) :white_check_mark: * [aad6ec6](https://github.com/aemsites/stericycle-shared/commit/aad6ec67f41b6679a8962aa32018f137daa2d82e) :white_check_mark:

[aem-code-sync[bot]]

Page	Scores	Audits	Google
/en-us/blog

[aem-code-sync[bot]]

Page	Scores	Audits	Google
/

[seanathero]

Some general observations when comparing to current fyi. If this PR is WIP these may be intended to address separately?

• Labels for checkboxes should be clickable along with the actual checkbox
• Irrelevant filters should be removed from list when selecting
• Elements shift horizontal position when results are updated
• Missing pagination

[seanathero]

Filters can be accessed via keyboard - this is a good A11y improved over the current implementation! 👍

[seanathero]

Mobile form factor seems incomplete - doesn't match current site. WIP?

[seanathero]

Based on update during stand-up it looks like there will be another PR for this so approving this version.

[dkuntze]

Still working on this.