aemsites / vg-macktrucks-com

Franklin V5 site for https://www.macktrucks.com
Apache License 2.0
1 stars 0 forks source link

Collage/Carousel blocks are broken #33

Open BeckyMedlin opened 2 days ago

BeckyMedlin commented 2 days ago

Issue Type

Bug

Summary

V2 collage/carousel blocks are not working as designed

Priority

Blocker

Description

Reported by @WendyKruger: Three collage/carousel blocks are broken (note: two of the three are not in the sidekick library):

  1. v2 stories carousel https://main--vg-macktrucks-com--hlxsites.hlx.page/block-library/blocks/v2-stories-carousel

  2. v2 image collage https://main--vg-macktrucks-com--hlxsites.hlx.page/block-library/blocks/v2-image-collage

  3. v2 category collage https://main--vg-macktrucks-com--hlxsites.hlx.live/tools/sidekick/library.html?plugin=blocks&path=/block-library/blocks/v2-category-collage&index=0 (See related issue #13 )

You can see all these on this page: https://main--vg-macktrucks-com--hlxsites.hlx.page/drafts/wendy.kruger/magazine/bulldog-article-title-length-exploration

Affected Device Classes

Desktop, Tablet, Mobile

Affected Browsers/Devices and Versions

Chrome

Steps to Reproduce

Navigate to page -- see examples here: https://main--vg-macktrucks-com--hlxsites.hlx.page/drafts/wendy.kruger/magazine/bulldog-article-title-length-exploration

Expected Results

Blocks are not displaying as designed.

Actual Results

See examples

Attachment

No response

BeckyMedlin commented 2 days ago

@girishdigrajkar Please verify issues -- do these need to be separate issues or is the root cause related?

girishdigrajkar commented 1 day ago

Validated and seems the root cause is that code is referring sidekick and fails with error. For V2 image collage block, it is not present in sidekick and fails due to same reason. Root cause is similar so, ok to have one fix for all above sub issue.