aemsites / vg-macktrucks-com

Franklin V5 site for https://www.macktrucks.com
Apache License 2.0
1 stars 0 forks source link

FR: Magazine Article layout #71

Open ZoeBeykirch opened 5 months ago

ZoeBeykirch commented 5 months ago

Context/Description

As a Mack Trucks content author, I want to adjust the Magazine template spacing. Since the site is responsive it will adjust dynamically with the viewport size. In this ticket we will focus on content max-width and address vertical spacing in another ticket.

Acceptance Criteria

User AC:

Non-functional AC:

Attachment / link to Figma

Desktop: https://www.figma.com/design/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?m=dev&node-id=14119-2389

Image

Mobile: https://www.figma.com/design/oNwe2jHIICPMIe551EY62l/Mack-Reskin---Full-Project?m=dev&node-id=2222-52896

Image

BeckyMedlin commented 1 month ago

Removed from sprint since this item must be completed after template is created. Once the template is working, the text content should get the styling. @mollyaljenkins I'm updating https://github.com/hlxsites/vg-macktrucks-com/issues/603 to reflect this dependency.

amglebihan commented 6 days ago

@ZoeBeykirch When reviewing the designs, it appears that the extra left/right space is only present around the V2 Pull Quote block. Should I adjust it specifically for this block? Additionally, we should modify the block's wrapper max-width rather than the left/right padding, as no padding is set—only a max-width, and the block is horizontally centred. Based on the designs, the max-width should be 689px instead of 1040px on desktop.

ZoeBeykirch commented 6 days ago

@WendyKruger

WendyKruger commented 6 days ago

@ZoeBeykirch When reviewing the designs, it appears that the extra left/right space is only present around the V2 Pull Quote block. Should I adjust it specifically for this block? Additionally, we should modify the block's wrapper max-width rather than the left/right padding, as no padding is set—only a max-width, and the block is horizontally centred. Based on the designs, the max-width should be 689px instead of 1040px on desktop.

per the Figma design there should be 288 px on the left and right of the subhead, attribution, and social parts and 375 px of padding on the left and right of the article text (including pull quote). The standard 200 px padding applies to the non-article blocks (related stories, etc.)

image image

amglebihan commented 6 days ago

@ZoeBeykirch @WendyKruger Since the site is responsive, we shouldn't refer to padding, as it will adjust dynamically with the viewport size. Instead, we should focus on content max-width.

I'll keep the max-width at 1040px for all blocks, except for the following:

ZoeBeykirch commented 1 day ago

@WendyKruger Hi. Alan is finalizing the styling for the Bulldog magazine article template and have a few remaining questions about the article's headline. The original AC stated that it should be an H1, but: